Fix build with GLM changes in Cesium Native #1594
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment,
GLM_FORCE_SIZE_T_LENGTHis still defined in the Unreal Build.cs, which - after we removed this define from Cesium Native - means linker errors result when trying to build Cesium for Unreal with the latest changes from Cesium Native. We can fix this by simply removing the define.Also, I've been receiving errors related to using an experimental header without defining
GLM_ENABLE_EXPERIMENTAL, despite the only place an experimental header is used in this codebase coming after a#define GLM_ENABLE_EXPERIMENTALdeclaration. I don't know what's causing this - something to do with Unreal's unity build? - but it can be fixed by definingGLM_ENABLE_EXPERIMENTALin the Build.cs.