Logs: only log once per unsupported primitive mode #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j9liu
reviewed
Apr 8, 2025
added 2 commits
April 8, 2025 17:58
In our context, we load many tilesets using the 'LINES' primitive mode, so logging the warning for each primitive would result in many redundancies...
Julot94
force-pushed
the
unsupported-primitive-logging-no-repeat
branch
from
60f1f4a to
fdfe329
Compare
|
@Julot94 just confirming if this is ready for another review? (I see new commits but didn't want to assume) |
Yes, it is (I should have added a separate comment to avoid confusion, sorry) |
|
No worries, thanks @Julot94 ! I'll merge this now 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our context, we load many tilesets using the 'LINES' primitive mode, so logging the warning for each primitive would result in many redundancies...