Remove use of defaultValue
#672
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll open this despite the open question of What's the future of
gltf-pipeline
? (or rather, to prevent the short-term answer to that "being broken"):The
defaultValue
function has been deprecated in CesiumJS, and is scheduled for removal in a few months. Thegltf-pipeline
library is stil used in several projects (with one of them being CesiumJS itself...). This PR removes the use ofdefaultValue
throughout the codebase, and replaces it with the nullish coalescing operator.(Note: This will likely cause merge conflicts with #669 . Depending on the timeline, we will have to fix the
defaultValue
deprecation first. In doubt, it should probably be possible to create a "replace-all"-regex for the changes here. I just did them manually, because they have just so been below the threshold where an automation seemed worthwhile, but that's subjective).