Restrict gltf URIs to relative paths by default; add --allowAbsolute as fallback to insecure behavior.

bin/gltf-pipeline.js

@@ -47,6 +47,13 @@ const argv = yargs
       type: "boolean",
       default: false,
     },
+    "allow-absolute": {
+      alias: "a",
+      describe:
+        "Allow gltf files to refer to file URLs outside of their source path",
+      type: "boolean",
+      default: false,
+    },
     json: {
       alias: "j",
       describe: "Convert the input glb to glTF.",
@@ -204,8 +211,15 @@ const options = {
   dracoOptions: dracoOptions,
   baseColorTextureNames: argv.baseColorTextureNames,
   baseColorFactorNames: argv.baseColorFactorNames,
+  allowAbsolute: argv.allowAbsolute,
 };
 
+if (options.allowAbsolute) {
+  console.warn(
+    "Warning: Allowing absolute buffer URIs; please double-check your gltf for potentially dangerous buffer URIs.",
+  );
+}
+
 const inputIsBinary = inputExtension === ".glb";
 const outputIsBinary = outputExtension === ".glb";
 

lib/readResources.js

@@ -150,6 +150,11 @@ function readFile(object, uri, saveResourceId, options) {
     ? path.relative(resourceDirectory, absolutePath)
     : path.basename(absolutePath);
 
+  if (relativePath.startsWith("..") && !options.allowAbsolute) {
+    throw new Error(
+      `Absolute paths are not permitted; use --allowAbsolute to disable this error.`,
+    );
+  }
   if (!defined(object.name)) {
     const extension = path.extname(relativePath);
     object.name = path.basename(relativePath, extension);