Fix initial token claim for new wallets

[sudo-shashank]

Summary of changes

Changes introduced in this pull request:

• Fallback to provided address when ID lookup fails for new wallets.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

• I have performed a self-review of my own code,
• I have made corresponding changes to the documentation. All new code
  adheres to the team's
  documentation standards,
• I have added tests that prove my fix is effective or that my feature works
  (if possible),
• I have made sure the CHANGELOG is up-to-date. All user-facing changes
  should be reflected in this document.

Summary by CodeRabbit

• Bug Fixes
  • Native token drips no longer fail when recipient ID resolution is unavailable; the transfer proceeds using the provided address.
  • Reduces intermittent faucet errors caused by lookup issues, improving reliability in unstable network conditions.
  • Enhances overall resiliency of the faucet flow without changing user-facing steps or requirements.

[coderabbitai]

Walkthrough

Recipient ID resolution during native token drip now uses a best-effort lookup: the controller calls rpc.lookup_id(recipient).await and, on failure, continues with the original recipient address instead of returning an error. No other logic was changed.

Changes

Cohort / File(s)	Summary
Faucet recipient lookup src/faucet/controller.rs	Replace error-propagating recipient ID lookup with best-effort rpc.lookup_id(recipient).await; on error or failure, fall back to the original recipient address. Control flow continues rather than bubbling the error.

Sequence Diagram(s)

sequenceDiagram
    actor Client
    participant Controller as Faucet Controller
    participant RPC as RPC Service
    participant Drip as Native Token Drip

    Client->>Controller: request_drip(recipient)
    Controller->>RPC: lookup_id(recipient)
    alt ID found
        RPC-->>Controller: Ok(Some(id))
        Controller->>Drip: drip(to = id)
    else ID not found or error
        RPC-->>Controller: Err / Ok(None)
        Controller->>Drip: drip(to = recipient)  <!-- fallback -->
    end
    Drip-->>Controller: result
    Controller-->>Client: response

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Calibnet token claim api #315 — Adjusts recipient ID resolution and fallback behavior for token claims, similar best-effort lookup pattern.

Suggested reviewers

• elmattic
• akaladarshi

Poem

Hop-hop! I lookup, then I leap,
If IDs hide, I will not weep—
I fallback fast, no rivers dry,
Tokens drip beneath the sky.
Carrot logs and sunny trace,
Best-effort paths keep steady pace.
Thump-thump: shipped with grace! 🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title “Fix initial token claim for new wallets” succinctly captures the main change, which is modifying the faucet’s lookup logic to correctly handle new wallets by falling back to the provided address on lookup failures. It directly relates to the code updates described and is neither overly broad nor vague. This phrasing is clear, focused on the primary fix, and understandable to teammates reviewing history. It avoids generic terms and unnecessary detail while highlighting the core functionality update.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch shashank/fix-new-wallet-claim

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov-commenter]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 39.37%. Comparing base (37b05f1) to head (2852c06).

Files with missing lines	Patch %	Lines
src/faucet/controller.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #328   +/-   ##
=======================================
  Coverage   39.37%   39.37%           
=======================================
  Files          40       40           
  Lines        2537     2537           
=======================================
  Hits          999      999           
  Misses       1538     1538           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sudo-shashank]

Preview URL: https://2852c06.forest-explorer-preview.workers.dev

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/faucet/controller.rs (1)

224-224: Verify that swallowing all lookup errors is acceptable.

The fallback to recipient on lookup failure correctly handles new wallets without ID addresses. However, this also silently swallows legitimate RPC/network errors without distinguishing them from the "no ID yet" case.

Ensure this trade-off is acceptable for your use case. If transient RPC failures are common, users might experience silent failures without clear error messages.

Consider adding logging to improve observability:

-                        let id_address = rpc.lookup_id(recipient).await.unwrap_or(recipient);
+                        let id_address = rpc.lookup_id(recipient).await.unwrap_or_else(|e| {
+                            log::debug!("ID lookup failed for {}, using original address: {}", recipient, e);
+                            recipient
+                        });

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 37b05f1 and 2852c06.

📒 Files selected for processing (1)

• src/faucet/controller.rs (1 hunks)