Skip to content

Conversation

@akaladarshi
Copy link
Collaborator

@akaladarshi akaladarshi commented Nov 4, 2025

Summary of changes

Changes introduced in this pull request:

  • update know blocks chceckpoint

Reference issue to close (if applicable)

Closes #6215

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

  • Chores
    • Added new epoch-to-header mappings for calibnet and mainnet.
    • Updated introductory header source reference from filfox to berryx.
    • Adjusted checkpoint template resource estimates (download size/time) for calibnet and mainnet.

@akaladarshi akaladarshi requested a review from a team as a code owner November 4, 2025 14:23
@akaladarshi akaladarshi requested review from hanabi1224 and sudo-shashank and removed request for a team November 4, 2025 14:23
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 4, 2025

Walkthrough

Added two checkpoint entries to build/known_blocks.yaml (calibnet epoch 3110397 and mainnet epoch 5443200) and updated download-size/comment lines in .github/CHECKPOINT_ISSUE_TEMPLATE.md. No code exports or behavioral logic changed.

Changes

Cohort / File(s) Change Summary
Checkpoint mappings
build/known_blocks.yaml
Added calibnet mapping 3110397 → bafy2bzaceb7fz2umktqqckzbygfhcun4avpd6g5pgrmhg4w4rvsuywbbptm6e and mainnet mapping 5443200 → bafy2bzacedisdelql35luibjoxk5jyw7iai5if4eezrjslwhtuqmcczdjahb2
Checkpoint issue template
.github/CHECKPOINT_ISSUE_TEMPLATE.md
Updated resource estimate comments for calibnet and mainnet (download size/time figures) — no command changes

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify the two epoch→CID values and formatting in build/known_blocks.yaml.
  • Confirm comment edits in .github/CHECKPOINT_ISSUE_TEMPLATE.md are accurate and consistent.

Possibly related issues

  • #5884 — Similar updates to build/known_blocks.yaml checkpoint mappings (same file/purpose).
  • #6016 — Adds epoch→header mappings to build/known_blocks.yaml (same intent).
  • #6127 — Modifies build/known_blocks.yaml to add/update checkpoint mappings.

Possibly related PRs

  • #6163 — Adds new epoch→CID checkpoint mappings to build/known_blocks.yaml (same file, similar entries).
  • #6017 — Updates build/known_blocks.yaml with checkpoint entries for calibnet and mainnet.
  • #5887 — Adds epoch-to-block-header mappings in build/known_blocks.yaml.

Suggested reviewers

  • hanabi1224
  • sudo-shashank
  • elmattic

Pre-merge checks and finishing touches

✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: update known blocks' accurately summarizes the main change, which is updating the known_blocks.yaml file and checkpoint resource estimates.
Linked Issues check ✅ Passed The PR successfully implements the required procedures from issue #6215: new checkpoints were added for both calibnet and mainnet, and build/known_blocks.yaml was manually updated with the new mappings.
Out of Scope Changes check ✅ Passed All changes are within scope: updates to known_blocks.yaml with new checkpoints and resource estimate updates in the checkpoint issue template align directly with issue #6215 requirements.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch akaladarshi/update-known-blocks

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2ff8466 and b2cc37d.

📒 Files selected for processing (2)
  • .github/CHECKPOINT_ISSUE_TEMPLATE.md (1 hunks)
  • build/known_blocks.yaml (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • build/known_blocks.yaml
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: hanabi1224
Repo: ChainSafe/forest PR: 6079
File: src/chain_sync/metrics.rs:6-7
Timestamp: 2025-09-16T12:55:26.955Z
Learning: HEAD_EPOCH references in shell scripts (like scripts/tests/calibnet_eth_mapping_check.sh) that extract data from `forest-cli info show` are unrelated to Rust metrics constants with the same name and should not be flagged when metrics cleanup is performed.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Build forest binaries on Linux AMD64
  • GitHub Check: cargo-publish-dry-run
  • GitHub Check: Build Ubuntu
  • GitHub Check: tests-release
  • GitHub Check: All lint checks
  • GitHub Check: tests
🔇 Additional comments (2)
.github/CHECKPOINT_ISSUE_TEMPLATE.md (2)

22-23: Resource estimates updated to reflect chain growth.

The estimates have been increased to match blockchain expansion over ~1 month:

  • calibnet: ~3G → ~6G (2x growth)
  • mainnet: ~60G → ~74G (~23% growth)

These appear reasonable and align with the new checkpoints being added to build/known_blocks.yaml (calibnet epoch 3110397, mainnet epoch 5443200). The template remains functional.


1-33: Minor: Verify PR checklist expectations for maintenance updates.

The PR checklist items (self-review, documentation, tests, changelog) remain unchecked. For a maintenance-only update like this—which adds checkpoints and updates documentation comments—some items may not strictly apply (e.g., "tests" for data-only checkpoint updates). However, verify whether your project policy requires a changelog entry or formal self-review signoff for routine checkpoint maintenance.


Comment @coderabbitai help to get the list of available commands and usage tips.

sudo-shashank
sudo-shashank previously approved these changes Nov 4, 2025
@akaladarshi akaladarshi enabled auto-merge November 4, 2025 14:29
#
# This file is maintained monthly - see `CHECKPOINT_ISSUE_TEMPLATE.md`
calibnet:
3110397: bafy2bzaceb7fz2umktqqckzbygfhcun4avpd6g5pgrmhg4w4rvsuywbbptm6e
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be 3110400?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, 3110400 - 3110398 are all null tipsets

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update it again, actually I made these changes in the afternoon, since then it got updated.

The current one is not wrong : https://beryx.io/fil/calibration/block-cid/bafy2bzaceb7fz2umktqqckzbygfhcun4avpd6g5pgrmhg4w4rvsuywbbptm6e

@akaladarshi akaladarshi added this pull request to the merge queue Nov 4, 2025
@akaladarshi akaladarshi removed this pull request from the merge queue due to a manual request Nov 4, 2025
Comment on lines +22 to +23
# - calibnet ~6G, ~5min on a droplet
# - mainnet ~74G, ~20mins on a droplet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The math doesn't add up really. 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cron: update known_blocks.yaml

5 participants