Skip to content

fix(sync/paseo): Do not use runtime mod instantiation #4496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 24, 2025
Merged

fix(sync/paseo): Do not use runtime mod instantiation #4496

merged 4 commits into from
Jan 24, 2025

Conversation

dimartiro
Copy link
Contributor

@dimartiro dimartiro commented Jan 23, 2025 •
edited
Loading

Changes

Get rid of runtime mod instantiation that was preventing us for instantiate the right runtime in the block with the isue

Tests

Since I cannot add the tests here I leave it commented and add this issue to run it in the future

make test

Issues

Closes: #4483

jimjbrettj
jimjbrettj approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@jimjbrettj jimjbrettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dimartiro dimartiro self-assigned this Jan 23, 2025
@dimartiro dimartiro added S-runtime issues related to the lib/runtime package. S-sync-paseo related to particular network syncing. P-high this should be addressed ASAP. A-in-QA-or-regression pull request or issues is currently in QA or regression testing phase. C-complex Complex changes across multiple modules. Possibly will require additional research. labels Jan 23, 2025
@dimartiro dimartiro merged commit 10a9197 into development Jan 24, 2025
26 checks passed
@dimartiro dimartiro deleted the diego/paseo-sync-issue branch January 24, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EclesioMeloJunior EclesioMeloJunior EclesioMeloJunior approved these changes

@jimjbrettj jimjbrettj jimjbrettj approved these changes

@timwu20 timwu20 Awaiting requested review from timwu20 timwu20 is a code owner

Assignees

@dimartiro dimartiro

Labels

A-in-QA-or-regression pull request or issues is currently in QA or regression testing phase. C-complex Complex changes across multiple modules. Possibly will require additional research. P-high this should be addressed ASAP. S-runtime issues related to the lib/runtime package. S-sync-paseo related to particular network syncing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Gossamer stops syncing Paseo at block #3796856

3 participants

@dimartiro @EclesioMeloJunior @jimjbrettj