feat(dot/network): introduce translation shim type for Network and Syncing interfaces (#4798)#4847
Open
Aliexe-code wants to merge 2 commits intoChainSafe:developmentfrom
Open
Conversation
…ncing interfaces Add foundation implementation of translation shim that implements both gossip.Network and gossip.Syncing interfaces. This shim serves as a bridge between the new interface definitions and the existing Gossamer network implementation. The shim is placed in a separate package (dot/network/shim) to avoid circular dependencies between internal/client/network and dot/network packages. Both TranslationShim and syncShim types are provided: - TranslationShim implements gossip.Network with 19 methods - syncShim implements gossip.Syncing[common.Hash, uint] with 4 methods - All methods currently panic as this is a foundational implementation - Future PRs will replace panic implementations with actual translations This implementation addresses issue ChainSafe#4798 and provides the foundation for subsequent network layer refactoring work. Acceptance criteria met: - Implements Network interface - Implements Syncing interface - All methods panic as required for foundation implementation - 100% test coverage with 26 test cases - Passes all linting checks
Aliexe-code
requested review from
EclesioMeloJunior,
jimjbrettj and
timwu20
as code owners
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
dot/network/shimpackagegossip.Networkinterface with 19 methods (TranslationShim type)gossip.Syncing[common.Hash, uint]interface with 4 methods (syncShim type)internal/client/networkanddot/networkTests
go test ./dot/network/shim/... -v
Issues
#4798