feat: implement async hash #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wemeetagain
force-pushed
the
cayman/hash-async
branch
from
3f19739 to
18351dc
Compare
wemeetagain
force-pushed
the
cayman/hash-async
branch
from
18351dc to
b98bee3
Compare
matthewkeil
reviewed
Jun 6, 2024
Comment on lines
+60
to
+67
| it("should asyncHash similarly to crypto.createHash('sha256')", async () => { | ||
| for (let i = 1; i <= 16; i++) { | ||
| test(`No of Chunks=${i}`, () => { | ||
| for (let j = 0; j < 255; j++) { | ||
| const input = Buffer.alloc(CHUNK_SIZE * i, j); | ||
| const output1 = Buffer.alloc((CHUNK_SIZE / 2) * i); | ||
| const output2 = Buffer.alloc((CHUNK_SIZE / 2) * i); | ||
| for (let j = 0; j < 255; j++) { | ||
| const input = Buffer.alloc(CHUNK_SIZE * i, j); | ||
| expectEqualHex(await hashAsync(input), nodeCryptoHash(input)); | ||
| } | ||
| } | ||
| }); |
Member
There was a problem hiding this comment.
Just split this into a separate test so there is only one expect per test. Also cleaned up the output, i added a describe on PR#3 to show the chunk size but seems unnecessary in retrospect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hashfunctionTODO