Skip to content

Conversation

tysonclugg
Copy link

Avoids issues with pnpm install and pnpm run test such as this:

test browser
ℹ Browser "chromium" setup complete.
✘ [ERROR] Could not resolve "mocha/mocha.js"

    <stdin>:8:18:
      8 │ import mocha from 'mocha/mocha.js'
        ╵                   ~~~~~~~~~~~~~~~~

  You can mark the path "mocha/mocha.js" as external to exclude it from the bundle, which will
  remove this error and leave the unresolved path in the bundle.

Avoids issues with `pnpm install` and `pnpm run test` such as this:
```
test browser
ℹ Browser "chromium" setup complete.
✘ [ERROR] Could not resolve "mocha/mocha.js"

    <stdin>:8:18:
      8 │ import mocha from 'mocha/mocha.js'
        ╵                   ~~~~~~~~~~~~~~~~

  You can mark the path "mocha/mocha.js" as external to exclude it from the bundle, which will
  remove this error and leave the unresolved path in the bundle.
```
@tysonclugg tysonclugg requested a review from a team as a code owner April 16, 2025 03:38
@achingbrain
Copy link
Collaborator

If these modules are not referenced directly in code, they're likely to break aegir dep-check. At least it would, if it was used here.

Is this a problem that using pnpm has introduced?

@tysonclugg
Copy link
Author

If these modules are not referenced directly in code, they're likely to break aegir dep-check. At least it would, if it was used here.

Ahh, you're right. It seems that a different package is missing the dependency.

Is this a problem that using pnpm has introduced?

The problem becomes visible when using pnpm, but ultimately it's still a dependency bug. But as you've pointed out, it's not a bug with this package directly.

Happy to close, thanks. :-)

@tysonclugg tysonclugg closed this Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants