fix(deps-dev): Add missing transient dev dependencies#522
Closed
tysonclugg wants to merge 1 commit intoChainSafe:masterfrom
Closed
fix(deps-dev): Add missing transient dev dependencies#522tysonclugg wants to merge 1 commit intoChainSafe:masterfrom
tysonclugg wants to merge 1 commit intoChainSafe:masterfrom
Conversation
Avoids issues with `pnpm install` and `pnpm run test` such as this:
```
test browser
ℹ Browser "chromium" setup complete.
✘ [ERROR] Could not resolve "mocha/mocha.js"
<stdin>:8:18:
8 │ import mocha from 'mocha/mocha.js'
╵ ~~~~~~~~~~~~~~~~
You can mark the path "mocha/mocha.js" as external to exclude it from the bundle, which will
remove this error and leave the unresolved path in the bundle.
```
Collaborator
|
If these modules are not referenced directly in code, they're likely to break Is this a problem that using |
Author
Ahh, you're right. It seems that a different package is missing the dependency.
The problem becomes visible when using Happy to close, thanks. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids issues with
pnpm installandpnpm run testsuch as this: