Skip to content

Conversation

@nflaig
Copy link
Member

@nflaig nflaig commented Oct 30, 2025

This includes ChainSafe/bun-ffi-z#19

@nflaig nflaig requested a review from a team as a code owner October 30, 2025 17:56
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @nflaig, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the @chainsafe/bun-ffi-z dependency to its latest patch version. This update necessitates adjustments to the FFI bindings, reflecting potential internal changes or new functionalities exposed by the updated library. The primary goal is to maintain compatibility and leverage the most recent improvements from the bun-ffi-z package.

Highlights

  • Dependency Update: The @chainsafe/bun-ffi-z dependency has been updated from version ^1.1.4 to ^1.1.5.
  • FFI Binding Changes: The src/binding.ts file, which defines the Foreign Function Interface (FFI) bindings, has undergone significant changes. This includes a reordering of existing function definitions and the introduction of new functions such as u64_to_bytes, bytes_to_u64, and bytes_to_u64_fast.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@nflaig nflaig merged commit b3499f8 into main Oct 30, 2025
2 checks passed
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the version of the @chainsafe/bun-ffi-z dependency from 1.1.4 to 1.1.5 in bun.lock and package.json. Additionally, it removes several functions related to snappy compression, persistent Merkle trees, pubkey index maps, async shuffling, and leveldb iterators from src/binding.ts, while adding new functions for byte conversions, proposer index computation, sync committee indices computation, error naming, hashtree hashing, and list shuffling. The review focuses on the removal of the functions in src/binding.ts.

@nflaig nflaig deleted the nflaig/bump-bun-ffi branch October 30, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants