Skip to content

Conversation

@nflaig
Copy link
Member

@nflaig nflaig commented Nov 29, 2024

Motivation

As per discussion in #7260 we need to get the attester index from serialized bytes.

Currently we get the following error if cache entry is used

Nov-28 13:33:21.898[network]         debug: Gossip batch validation beacon_attestation threw a non-AttestationError - Cannot read properties of null (reading 'attesterIndex')
TypeError: Cannot read properties of null (reading 'attesterIndex')
    at validateAttestationNoSignatureCheck (file:///usr/app/packages/beacon-node/src/chain/validation/attestation.ts:426:93)
    at validateGossipAttestationsSameAttData (file:///usr/app/packages/beacon-node/src/chain/validation/attestation.ts:119:43)
    at Object.beacon_attestation (file:///usr/app/packages/beacon-node/src/network/processor/gossipHandlers.ts:625:64)
    at NetworkProcessor.gossipValidatorBatchFn (file:///usr/app/packages/beacon-node/src/network/processor/gossipValidatorFn.ts:36:75)
    at NetworkProcessor.processPendingGossipsubMessage (file:///usr/app/packages/beacon-node/src/network/processor/index.ts:438:20)
    at NetworkProcessor.executeWork (file:///usr/app/packages/beacon-node/src/network/processor/index.ts:398:16)
    at NetworkProcessor.pushPendingGossipsubMessageToQueue (file:///usr/app/packages/beacon-node/src/network/processor/index.ts:310:10)
    at NetworkProcessor.onPendingGossipsubMessage (file:///usr/app/packages/beacon-node/src/network/processor/index.ts:298:10)
    at NetworkEventBus.emit (node:events:520:28)

Description

Get attester index from single attestation bytes if cache is used

@nflaig nflaig requested a review from a team as a code owner November 29, 2024 09:50
@codecov
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 48.42%. Comparing base (cfe6c89) to head (5a665a5).
Report is 1 commits behind head on devnet-5.

Additional details and impacted files
@@             Coverage Diff              @@
##           devnet-5    #7264      +/-   ##
============================================
- Coverage     48.44%   48.42%   -0.02%     
============================================
  Files           602      602              
  Lines         40321    40331      +10     
  Branches       2057     2057              
============================================
  Hits          19532    19532              
- Misses        20751    20761      +10     
  Partials         38       38              

Copy link
Contributor

@twoeths twoeths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nflaig nflaig merged commit f8e2068 into devnet-5 Nov 29, 2024
17 checks passed
@nflaig nflaig deleted the nflaig/attester-index-from-bytes branch November 29, 2024 11:02
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.26.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants