feat: add FOCIL beacon metrics #8062
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KatyaRyazantseva
added
the
scope-metrics
|
Fork-choice metrics are temporary and expected to be moved to beacon after beacon specs #4351 merge and implementation. |
Comment on lines
+1541
to
+1549
| metrics?.eip7805.inclusionListProposed.inc(); | ||
|
|
||
| chain.emitter.emit(routes.events.EventType.inclusionList, { | ||
| version: config.getForkName(signedInclusionList.message.slot), | ||
| data: signedInclusionList, | ||
| }); | ||
|
|
||
| await network.publishInclusionList(signedInclusionList); | ||
| metrics?.eip7805.inclusionListBroadcasted.inc(); |
There was a problem hiding this comment.
inclusionListProposed and inclusionListBroadcasted seem to duplicate each other. I would like to hear from FOCIL team and other clients if it makes sense to have both.
Comment on lines
+80
to
+89
| inclusionListValid: register.counter<{source: InclusionListSource}>({ | ||
| name: "beacon_valid_inclusion_lists_total", | ||
| help: "Total number of valid inclusion lists", | ||
| labelNames: ["source"], | ||
| }), | ||
| inclusionListInvalid: register.counter<{source: InclusionListSource; reason: InvalidInclusionListReason}>({ | ||
| name: "beacon_invalid_inclusion_lists_total", | ||
| help: "Total number of invalid inclusion lists", | ||
| labelNames: ["source", "reason"], | ||
| }), |
There was a problem hiding this comment.
Need these metrics per slot
| */ | ||
| export function getMetrics(register: MetricsRegister) { | ||
| return { | ||
| inclusionListEquivocating: register.counter<{source: FCInclusionListSource}>({ |
There was a problem hiding this comment.
Need this metric per slot
| const {slot, validatorIndex, transactions, inclusionListCommitteeRoot} = inclusionList.message; | ||
|
|
||
| // [REJECT] The size of message is within upperbound MAX_BYTES_PER_INCLUSION_LIST | ||
| // TODO EIP-7805: spec is outdated, we need to check total size of all transactions | ||
| const inclusionListSize = transactions.reduce((total, transaction) => total + transaction.byteLength, 0); | ||
| if (inclusionListSize > chain.config.MAX_BYTES_PER_INCLUSION_LIST) { | ||
| metrics?.eip7805.inclusionListInvalid.inc({source, reason: InvalidInclusionListReason.maxSizeExceeded}); | ||
| metrics?.eip7805.invalidInclusionListByteSize.inc(inclusionListSize); |
There was a problem hiding this comment.
Do we need source and reason for invalidInclusionListByteSize as well? Question for the FOCIL team.
Comment on lines
+120
to
+129
| getInclusionListV1Requests: register.counter({ | ||
| name: "beacon_engine_getInclusionListV1_requests_total", | ||
| help: "Total number of getInclusionListV1 requests sent", | ||
| }), | ||
| getInclusionListV1ResponseTime: register.histogram({ | ||
| name: "beacon_engine_getInclusionListV1_response_time_seconds", | ||
| help: "Response time of getInclusionListV1 requests", | ||
| buckets: [0.01, 0.05, 0.1, 0.5, 1, 2.5, 5, 7.5], | ||
| }), | ||
| updatePayloadWithInclusionListV1Requests: register.counter({ |
There was a problem hiding this comment.
Do we need responses count here? Seems like there shouldn't be any losses for engine api.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add FOCIL metrics from beacon metrics specs to observe FOCIL.
Description
This PR adds the list of FOCIL beacon metrics specs #16.
Steps to test or reproduce
Observe metrics using Kurtosis FOCIL dashboard.