-
-
Notifications
You must be signed in to change notification settings - Fork 410
feat: improve getBlobsV2 #8282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve getBlobsV2 #8282
Conversation
| throw Error("Promise Constructor was not executed immediately"); | ||
| } | ||
|
|
||
| const gotColumnsFromExecution = await getDataColumnsFromExecution( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the only change in this file is to remove getDataColumnsFromExecution call, but it caused a lot of diffs due to indentation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## unstable #8282 +/- ##
============================================
- Coverage 54.07% 53.84% -0.24%
============================================
Files 849 849
Lines 64121 64195 +74
Branches 4853 4825 -28
============================================
- Hits 34674 34566 -108
- Misses 29370 29554 +184
+ Partials 77 75 -2 🚀 New features to boost your workflow:
|
Performance Report✔️ no performance regression detected Full benchmark results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
call getBlobsV2 once per slot, triggered by the first seen beacon_block or data_column_sidecar gossip message
agree with this, the effectiveness of getBlobsV2 will be questionable anyways on mainnet due to private blob transactions and once we increase blob count further it seems likely that columns disseminate faster through the network than blobs on the EL side
|




Motivation
Description
getBlobsV2, consume the newfromHexInto()api in feat: fromHexInto() api #8275getDataColumnsFromExecution()and track in metricsCloses #8281
Closes #8271
Test on
fusaka-devnet-3