chore: update payload_attributes event test data
#8308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Summary of Changes
Hello @nflaig, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates existing test data and configurations to reflect recent changes in the Ethereum Beacon API specification. The primary goal is to ensure that tests for payload_attributes events pass correctly by using the updated Electra fork data structure and including a newly required field, thereby improving the accuracy and coverage of API specification compliance checks.
Highlights
- Test Data Alignment: The payload_attributes event test data has been updated to align with recent changes in the Ethereum Beacon APIs specification (specifically, PR #550).
- Test Coverage Improvement: The payload_attributes topic is no longer ignored in API specification tests, allowing for more comprehensive validation.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the test data for the payload_attributes event to align with recent specification changes. It correctly modifies the fork version to electra, updates the SSZ deserialization, and adds the new parent_beacon_block_root field. Additionally, the corresponding test, which was previously ignored, is now enabled. The changes are accurate and effectively address the motivation of the PR. The code quality is good, and I have no suggestions for improvement.
nflaig
commented
Sep 2, 2025
| version: ForkName.capella, | ||
| data: ssz.capella.SSEPayloadAttributes.fromJson({ | ||
| version: ForkName.electra, | ||
| data: ssz.electra.SSEPayloadAttributes.fromJson({ |
Member
Author
There was a problem hiding this comment.
technically this only needs to be deneb since there are no changes since then but to match example version
nflaig
changed the title
payload_attributes event test data
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #8308 +/- ##
============================================
- Coverage 54.14% 54.13% -0.01%
============================================
Files 849 849
Lines 63996 64017 +21
Branches 4850 4851 +1
============================================
+ Hits 34649 34655 +6
- Misses 29270 29285 +15
Partials 77 77 🚀 New features to boost your workflow:
|
Contributor
Performance Report🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
wemeetagain
approved these changes
Sep 2, 2025
Member
|
🎉 This PR is included in v1.34.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is required to pass spec tests since spec example was updated in ethereum/beacon-APIs#550
Description
Update
payload_attributesevent test dataNote: we already emit all required fields, no changes needed there