fix: rough out validateColumnsByRangeResponse #8482
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Found two small bugs while looking through devnet logs
and
There is a bug in
validateColumnsByRangeResponse
that is passing through an empty array ofblockColumnSidecars
on this linelodestar/packages/beacon-node/src/sync/utils/downloadByRange.ts
Line 770 in bca2040
cacheByRangeResponses
. While going through the validation with a fine toothed comb I noticed that there were a couple of conditions that we are not checking per spec.Scope
Changed heuristic for how columns are validated in ByRange and added in checks for column delivery in
(slot, column_index)
order.