chore: fix typo in test/unit/sanityCheck.test.ts hiding root cause of error

[MattHandzel]

Replace BigInt(1) ** BigInt(15); to BigInt(10) ** BigInt(15);

Fixes 6358

Motivation

When trying to fix flaky test/unit/sanityCheck.test.ts test in #6358 I noticed the test has a typo causing it to pass when I don't think it should. I don't have time to fix the underlying issue but thought I should let you know there is a deeper issue.

Description

It appears there to be a typo in the test, multiplying 1^15 instead of 10^15. The test now fails properly instead of incorrectly passing.

Steps to test or reproduce

git checkout matthandzel/fixing-typo-in-sanity-check-test
yarn install
yarn build
yarn vitest run test/unit/sanityCheck.test.ts

[gemini-code-assist]

Summary of Changes

Hello @MattHandzel, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical typo within a unit test (sanityCheck.test.ts) that was causing it to incorrectly pass. By changing a BigInt calculation from 1^15 to 10^15, the test now accurately reflects its intended logic and fails, thereby unmasking a deeper, previously obscured issue that contributes to test flakiness.

Highlights

• Test Typo Correction: Corrected a mathematical typo in packages/state-transition/test/unit/sanityCheck.test.ts by changing BigInt(1) ** BigInt(15) to BigInt(10) ** BigInt(15).
• Revealing Root Cause: This fix ensures the test now fails as intended, exposing a previously hidden underlying issue related to flaky tests (referenced as Flaky tests #6358).
• Motivation: The change was motivated by an attempt to fix a flaky test, where the typo was discovered to be masking the true problem, allowing the test to incorrectly pass.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a typo in a unit test that was causing it to pass when it should have failed. The calculation for targetStake is now correct. I've provided one suggestion to improve the readability of the code by using modern BigInt syntax.

[gemini-code-assist]

To improve readability and use modern BigInt syntax, you can use n literals for BigInt values. This avoids multiple BigInt() constructor calls and makes the intent of calculating 10^15 clearer.

Suggested change

	const targetStake = BigInt(targetStakeYWei) * BigInt(10) ** BigInt(15);
	const targetStake = BigInt(targetStakeYWei) * (10n ** 15n);

[wemeetagain]

good catch! looks like the test has always been bugged since it was added a75ef9b