-
-
Notifications
You must be signed in to change notification settings - Fork 410
test: update to vitest 4 to use builtin bun support #8599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nazarhussain
wants to merge
14
commits into
unstable
Choose a base branch
from
nh/vitest-4-bun
base: unstable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+976
−1,667
Open
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
4ef2056
uprade vitest to v4
nazarhussain adbcf21
update all config to remove bun specific code
nazarhussain d3ac219
fix types
nazarhussain 7692fa0
update option for e2e tests
nazarhussain ac7c670
fix bundle vite config
nazarhussain ef7dfaf
fix esm resolution issue in bun
nazarhussain 625f126
fix mocks to new format
nazarhussain 6f96059
fix browser tests
nazarhussain 9b6ec47
update browser driver to playwright
nazarhussain e97b053
update the browser provider
nazarhussain db487e5
fix e2e tests
nazarhussain b5565dc
remove webkit from browser list
nazarhussain 083c4f8
update the package.json and remove webdriver
nazarhussain c720435
remove untracked file
nazarhussain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,12 @@ | ||
| import path from "node:path"; | ||
| import {ViteUserConfig, defineConfig} from "vitest/config"; | ||
| import {TestUserConfig, defineConfig} from "vitest/config"; | ||
| import {browserTestProject} from "./configs/vitest.config.browser.js"; | ||
| import {e2eMainnetProject, e2eMinimalProject} from "./configs/vitest.config.e2e.js"; | ||
| import {specProjectMainnet, specProjectMinimal} from "./configs/vitest.config.spec.js"; | ||
| import {typesTestProject} from "./configs/vitest.config.types.js"; | ||
| import {unitTestMainnetProject, unitTestMinimalProject} from "./configs/vitest.config.unit.js"; | ||
|
|
||
| const isBun = "bun" in process.versions; | ||
|
|
||
| export function getReporters(): ViteUserConfig["test"]["reporters"] { | ||
| if (isBun) return [["default", {summary: false}]]; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That was hack to for older process pool, not needed now. |
||
| export function getReporters(): TestUserConfig["reporters"] { | ||
| if (process.env.GITHUB_ACTIONS) return ["verbose", "hanging-process", "github-actions"]; | ||
| if (process.env.TEST_COMPACT_OUTPUT) return ["basic", "hanging-process"]; | ||
|
|
||
|
|
@@ -18,7 +15,7 @@ export function getReporters(): ViteUserConfig["test"]["reporters"] { | |
|
|
||
| export default defineConfig({ | ||
| test: { | ||
| workspace: [ | ||
| projects: [ | ||
| { | ||
| extends: true, | ||
| ...unitTestMinimalProject, | ||
|
|
@@ -77,9 +74,8 @@ export default defineConfig({ | |
| onConsoleLog: () => !process.env.TEST_QUIET_CONSOLE, | ||
| coverage: { | ||
| enabled: false, | ||
| include: ["packages/**/src/**.{ts}"], | ||
| clean: true, | ||
| all: false, | ||
| extension: [".ts"], | ||
| provider: "v8", | ||
| reporter: [["lcovonly", {file: "lcov.info"}], ["text"]], | ||
| reportsDirectory: "./coverage", | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This combination will replace
singleFork: truein from older version