Skip to content

feat: enable gloas spec tests #8609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: unstable
Choose a base branch
from
+9 −3
Open

feat: enable gloas spec tests #8609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1e6eeb8
Update container
ensi321 Nov 3, 2025
4891913
Enable partial gloas spec tests
ensi321 Nov 5, 2025
e387231
Update spec test version
ensi321 Nov 5, 2025
0cc4863
Skip compatible union tests
ensi321 Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/beacon-node/test/spec/general/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ specTestIterator(
"ProgressiveSingleFieldContainerTestStruct",
"ProgressiveSingleListContainerTestStruct",
"ProgressiveComplexTestStruct",
"CompatibleUnionA",
"CompatibleUnionBC",
"CompatibleUnionABCA",
]),
},
},
Expand Down
2 changes: 1 addition & 1 deletion packages/beacon-node/test/spec/specTestVersioning.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import {DownloadTestsOptions} from "@lodestar/spec-test-util/downloadTests";
const __dirname = path.dirname(fileURLToPath(import.meta.url));

export const ethereumConsensusSpecsTests: DownloadTestsOptions = {
specVersion: "v1.6.0-beta.0",
specVersion: "v1.6.0-beta.2",
// Target directory is the host package root: 'packages/*/spec-tests'
outputDir: path.join(__dirname, "../../spec-tests"),
specTestsRepoUrl: "https://github.com/ethereum/consensus-specs",
Expand Down
4 changes: 3 additions & 1 deletion packages/beacon-node/test/spec/utils/specTestIterator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ const coveredTestRunners = [
// ],
// ```
export const defaultSkipOpts: SkipOpts = {
skippedForks: ["eip7732", "eip7805", "gloas"],
skippedForks: ["eip7732", "eip7805"],
// TODO: capella
// BeaconBlockBody proof in lightclient is the new addition in v1.3.0-rc.2-hotfix
// Skip them for now to enable subsequently
Expand All @@ -69,6 +69,8 @@ export const defaultSkipOpts: SkipOpts = {
/^electra\/light_client\/single_merkle_proof\/BeaconBlockBody.*/,
/^fulu\/light_client\/single_merkle_proof\/BeaconBlockBody.*/,
/^.+\/light_client\/data_collection\/.*/,
/^gloas\/(?!.*ssz_static).*$/,
/^gloas\/ssz_static\/ForkChoiceNode.*$/,
],
skippedTests: [],
skippedRunners: [],
Expand Down
2 changes: 1 addition & 1 deletion packages/params/test/e2e/ensure-config-is-synced.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {loadConfigYaml} from "../yaml.js";
// Not e2e, but slow. Run with e2e tests

/** https://github.com/ethereum/consensus-specs/releases */
const specConfigCommit = "v1.6.0-beta.0";
const specConfigCommit = "v1.6.0-beta.2";
/**
* Fields that we filter from local config when doing comparison.
* Ideally this should be empty as it is not spec compliant
Expand Down
1 change: 1 addition & 0 deletions packages/types/src/gloas/sszTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ export const DataColumnSidecar = new ContainerType(
kzgProofs: fuluSsz.DataColumnSidecar.fields.kzgProofs,
// signedBlockHeader: phase0Ssz.SignedBeaconBlockHeader, // Removed in GLOAS:EIP7732
// kzgCommitmentsInclusionProof: KzgCommitmentsInclusionProof, // Removed in GLOAS:EIP7732
slot: Slot, // New in GLOAS:EIP7732
beaconBlockRoot: Root, // New in GLOAS:EIP7732
},
{typeName: "DataColumnSidecar", jsonCase: "eth2"}
Expand Down
Loading