chore: remove holesky configs and update tests to hoodi #8622

KoxyG · 2025-11-20T21:39:49Z

Motivation

Replace deprecated Holesky network support with Hoodi testnet configuration. Hoodi is a new Ethereum testnet that will serve as a replacement testnet, and this change updates Lodestar to support the new network configuration.

Description

This PR removes Holesky network configuration and replaces all references with Hoodi testnet support. Changes include:

Removed packages/cli/src/networks/holesky.ts network file
Removed packages/config/src/chainConfig/networks/holesky.ts chain config
Updated all network references from "holesky" to "hoodi" across CLI, config, and test files
Added Hoodi network configuration with proper chain parameters, genesis data, and bootnodes
Updated default environment configuration
Updated unit tests to reflect the network change

Closes ##8615

AI Assistance Disclosure

External Contributors: I have read the contributor guidelines and disclosed my usage of AI below.

-PR content was developed using Cursor for code updates and explanations; I reviewed and verified all changes manually.

gemini-code-assist · 2025-11-20T21:40:11Z

Summary of Changes

Hello @KoxyG, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant refactoring to deprecate and remove all traces of the Holesky testnet, replacing them with the Hoodi testnet. This change involves deleting specific network definition files, updating network lists and types, and modifying test cases and command examples to reflect the new Hoodi network. The overall purpose is to streamline the codebase by removing outdated network configurations and integrating the current testnet strategy.

Highlights

Holesky Network Deprecation: The Holesky testnet configuration and all its associated files have been completely removed from the codebase, indicating its deprecation.
Hoodi Network Integration: All references to 'holesky' across various configuration files, type definitions, and utility functions have been systematically replaced with 'hoodi', establishing Hoodi as the new target testnet.
Test Suite Updates: Unit tests related to network configurations, paths, and interop comparisons have been updated to align with the transition from Holesky to Hoodi, ensuring test accuracy for the new network.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request removes the 'holesky' testnet configuration and references from the codebase. The changes are mostly mechanical, involving file deletions and find-and-replace operations. The tests have been updated to use the 'hoodi' testnet where 'holesky' was previously used. The changes appear correct and consistent with the goal of removing the 'holesky' network. I've added one comment to improve the documentation in default.env.

default.env

packages/flare/src/cmds/selfSlashAttester.ts

packages/validator/test/unit/utils/params.test.ts

philknows · 2025-11-26T02:39:35Z

Please also make sure you look at all the unit tests that still depend on holesky configs. Example:
https://github.com/ChainSafe/lodestar/blob/unstable/packages/validator/test/unit/utils/interopConfigs.ts

philknows · 2025-12-03T14:15:38Z

Converting to draft until ready for re-review

KoxyG · 2025-12-05T20:23:01Z

Hi @philknows @nflaig I just made the changes

nflaig

Great job @KoxyG, looks pretty good

nflaig · 2025-12-05T22:25:34Z

packages/validator/src/util/params.ts

+      // Parse JSON string if needed (interopConfigs stores BLOB_SCHEDULE as JSON string)
+      const remoteBlobScheduleValue =
+        typeof externalSpecJson[key] === "string" ? JSON.parse(externalSpecJson[key]) : externalSpecJson[key];
      const localBlobSchedule = deserializeBlobSchedule(localSpecJson[key]).sort((a, b) => a.EPOCH - b.EPOCH);
-      const remoteBlobSchedule = deserializeBlobSchedule(externalSpecJson[key]).sort((a, b) => a.EPOCH - b.EPOCH);
+      const remoteBlobSchedule = deserializeBlobSchedule(remoteBlobScheduleValue).sort((a, b) => a.EPOCH - b.EPOCH);


these changes shouldn't be required, the BLOB_SCHEDULE should be an array, not a string

nflaig · 2025-12-05T22:32:39Z

packages/validator/test/unit/utils/interopConfigs.ts

+  BASE_REWARD_FACTOR: "64",
+  BELLATRIX_FORK_EPOCH: "0",
+  BELLATRIX_FORK_VERSION: "0x30000910",
+  BLOB_SCHEDULE: '[{"EPOCH": "52480", "MAX_BLOBS_PER_BLOCK": "15"}, {"EPOCH": "54016", "MAX_BLOBS_PER_BLOCK": "21"}]',


what's the reason that this is a stringifed array? clients should be returning this as a json array

nflaig · 2025-12-05T22:33:44Z

packages/validator/test/unit/utils/params.test.ts

+  tekuHoodiConfig,
+} from "./interopConfigs.js";

 const testCases: {name: string; items: [ChainConfig, Record<string, string>]}[] = [


you will need to update this type and use SpecJson from @lodestar/config

Suggested change

const testCases: {name: string; items: [ChainConfig, Record<string, string>]}[] = [

const testCases: {name: string; items: [ChainConfig, SpecJson]}[] = [

nflaig · 2025-12-05T22:37:25Z

there are two more places we should update to hoodi

lodestar/packages/flare/src/cmds/selfSlashAttester.ts

Line 22 in 1f2a3a4

command: "self-slash-proposer --network holesky",

(also feel free to correct the example command)

lodestar/packages/era/src/era/util.ts

Line 13 in 1f2a3a4

/** CONFIG_NAME field of runtime config (mainnet, sepolia, holesky, etc.) */

fix changes frm holesky to hoodi

6a5cc08

KoxyG requested a review from a team as a code owner November 20, 2025 21:39

KoxyG changed the title ~~fix changes from holesky to hoodi~~ fix: remove holesky configs and update tests to hoodi Nov 20, 2025

gemini-code-assist bot reviewed Nov 20, 2025

View reviewed changes

default.env Outdated Show resolved Hide resolved

fix changes frm holesky to hoodi

8d071d0

philknows reviewed Nov 26, 2025

View reviewed changes

packages/flare/src/cmds/selfSlashAttester.ts Outdated Show resolved Hide resolved

philknows reviewed Nov 26, 2025

View reviewed changes

packages/validator/test/unit/utils/params.test.ts Outdated Show resolved Hide resolved

philknows reviewed Nov 26, 2025

View reviewed changes

packages/validator/test/unit/utils/params.test.ts Show resolved Hide resolved

Merge branch 'ChainSafe:unstable' into hoodi

640d95c

philknows marked this pull request as draft December 3, 2025 14:15

KoxyG and others added 3 commits December 5, 2025 20:07

Merge branch 'ChainSafe:unstable' into hoodi

6fb6873

fixed the hoodie issue

946ff94

fix the hoodi conflict

34c99b7

KoxyG marked this pull request as ready for review December 5, 2025 20:22

nflaig changed the title ~~fix: remove holesky configs and update tests to hoodi~~ chore: remove holesky configs and update tests to hoodi Dec 5, 2025

nflaig reviewed Dec 5, 2025

View reviewed changes

	const testCases: {name: string; items: [ChainConfig, Record<string, string>]}[] = [
	const testCases: {name: string; items: [ChainConfig, SpecJson]}[] = [

Uh oh!

chore: remove holesky configs and update tests to hoodi #8622

Are you sure you want to change the base?

chore: remove holesky configs and update tests to hoodi #8622

Conversation

KoxyG commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Nov 20, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

philknows commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

philknows commented Dec 3, 2025

Uh oh!

KoxyG commented Dec 5, 2025

Uh oh!

nflaig left a comment

Choose a reason for hiding this comment

Uh oh!

nflaig Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

nflaig Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nflaig Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

nflaig commented Dec 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

KoxyG commented Nov 20, 2025 •

edited

Loading

philknows commented Nov 26, 2025 •

edited

Loading

nflaig Dec 5, 2025 •

edited

Loading