feat(types): add support for blinded block variants #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
spiral-ladder
force-pushed
the
bing/blinded-types
branch
2 times, most recently
from
5913a73 to
f27e4a8
Compare
spiral-ladder
commented
Jul 28, 2025
There was a problem hiding this comment.
this is extracted to #31
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| }; | ||
| } | ||
|
|
||
| pub fn getGraffity(self: *const BlindedBeaconBlockBody) ssz.primitive.Bytes32.Type { |
There was a problem hiding this comment.
There's a typo in the function name getGraffity() - it should be getGraffiti() to match the field name graffiti in the block body structure. This would maintain consistency with the field naming convention used throughout the codebase.
Suggested change
| pub fn getGraffity(self: *const BlindedBeaconBlockBody) ssz.primitive.Bytes32.Type { | |
| pub fn getGraffiti(self: *const BlindedBeaconBlockBody) ssz.primitive.Bytes32.Type { |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
inconsistent with the upstream branch; not implementing for now.
Adds support for `BlindedBeaconBlock` and `BlindedBeaconBlockBody` with a sanity test.
spiral-ladder
force-pushed
the
bing/blinded-types
branch
from
c8960c2 to
02762fd
Compare
spiral-ladder
added a commit
that referenced
this pull request
Jul 30, 2025
feat(types): add support for blinded block variants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
BlindedBeaconBlockandBlindedBeaconBlockBodywith a sanity test.