-
Notifications
You must be signed in to change notification settings - Fork 3
chore: remove hex
#76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Most of the utils in `hex.zig` are not being used, and what's left of those used ones (2 of them) are only used in `config` and `test_utils`, so we might as well put them where they're used. This alsos simplifies imports/dependencies for consumer libraries.
Summary of ChangesHello @spiral-ladder, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undertakes a significant refactoring effort by eliminating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a nice simplification, removing the hex module and relocating its utilities to where they are used. My review focuses on a few areas to further improve the code: enhancing the safety of the moved functions, suggesting the restoration of a useful developer feature in the build script, and ensuring that test coverage for the moved utilities is maintained. Overall, the changes are positive and improve the project structure.
0fdb1fa to
0198f3b
Compare
0198f3b to
0637158
Compare
Most of the utils in
hex.zigare not being used, and what's left of those used ones (2 of them) are only used inconfigandtest_utils, so we might as well put them where they're used.This alsos simplifies imports/dependencies for consumer libraries.