Skip to content

Conversation

@spiral-ladder
Copy link
Contributor

Most of the utils in hex.zig are not being used, and what's left of those used ones (2 of them) are only used in config and test_utils, so we might as well put them where they're used.

This alsos simplifies imports/dependencies for consumer libraries.

Most of the utils in `hex.zig` are not being used, and what's left of
those used ones (2 of them) are only used in `config` and `test_utils`,
so we might as well put them where they're used.

This alsos simplifies imports/dependencies for consumer libraries.
@spiral-ladder spiral-ladder self-assigned this Oct 29, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @spiral-ladder, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant refactoring effort by eliminating the src/hex.zig utility file. The functions previously housed there were either found to be unused and thus removed, or were highly specialized and have been relocated to the specific modules (config and state_transition/test_utils) where they are actually consumed. This change aims to reduce unnecessary dependencies, improve modularity, and simplify the overall build configuration.

Highlights

  • Removal of hex.zig module: The dedicated src/hex.zig file has been entirely removed, streamlining the project structure.
  • Relocation of hexToBytesComptime: The hexToBytesComptime utility function has been moved to src/config/root.zig as it was primarily used within the configuration files.
  • Relocation of hexToBytes and hexToRoot: The hexToBytes and hexToRoot utility functions have been moved to src/state_transition/test_utils/root.zig to serve their specific usage in test utilities.
  • Simplified build configuration: The build.zig and zbuild.zon files have been updated to remove references to the hex module and simplify test filter options.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a nice simplification, removing the hex module and relocating its utilities to where they are used. My review focuses on a few areas to further improve the code: enhancing the safety of the moved functions, suggesting the restoration of a useful developer feature in the build script, and ensuring that test coverage for the moved utilities is maintained. Overall, the changes are positive and improve the project structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants