Updating Countly to the latest version and supressing bunch of the warnings coming from it. #1251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Cleaned up SDK (i.e. added bunch of pragma disables) so that there are no warnings.
auto-assign
bot
requested review from
creeppak,
juans-chainsafe,
rob1997 and
sneakzttv
kantagara
added
ready-to-merge
kantagara
commented
Dec 4, 2024
Packages/io.chainsafe.web3-unity/Runtime/Libraries/ChainSafe.Gaming.WalletConnect.dll.meta
Show resolved
Hide resolved
kantagara
commented
Dec 4, 2024
...eProject/Assets/Samples/web3.unity SDK/3.0.6/Web3.Unity Samples/Scripts/Samples/EvmSample.cs
Show resolved
Hide resolved
sneakzttv
approved these changes
Dec 4, 2024
kantagara
added
ready-to-merge
kantagara
added
ready-to-merge
rob1997
approved these changes
Dec 5, 2024
juans-chainsafe
suggested changes
Dec 6, 2024
creeppak
approved these changes
Dec 11, 2024
rob1997
force-pushed
the
nikola/countly-issues
branch
from
d4e005f to
d382322
Compare
rob1997
force-pushed
the
nikola/countly-issues
branch
from
d382322 to
f01604d
Compare
rob1997
force-pushed
the
nikola/countly-issues
branch
from
f01604d to
d4ccfb1
Compare
rob1997
force-pushed
the
nikola/countly-issues
branch
from
d4ccfb1 to
8184296
Compare
rob1997
force-pushed
the
nikola/countly-issues
branch
from
8184296 to
e187f3d
Compare
rob1997
force-pushed
the
nikola/countly-issues
branch
from
e187f3d to
e458daf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #1237 #1221