Add singlePage page Property #58
Conversation
WalkthroughA new Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant PagePropertyBuilder
participant PageProperties
Client->>PagePropertyBuilder: SetSinglePage(true)
PagePropertyBuilder->>PageProperties: SinglePage = true
Note right of PageProperties: SinglePage property set for PDF generation
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
lib/Domain/Requests/Facets/PageProperties.cs (1)
140-144: Well-implemented property with clear documentation.The
SinglePageproperty is properly implemented with:
- Correct
MultiFormHeaderattribute referencing the constant fromConstants.cs- Appropriate boolean type for the single-page feature
- Consistent formatting with other properties in the class
The XML documentation clearly explains the purpose, though it could benefit from more specific details about how it interacts with existing paper size settings.
Consider enhancing the documentation to be more specific about the override behavior:
/// <summary> -/// Get or set a value indicating whether the PDF should be generated as a single page. (Will override the paper size) +/// Get or set a value indicating whether the PDF should be generated as a single page. +/// When true, this setting overrides the PaperWidth and PaperHeight properties to fit all content on a single page. /// </summary>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
lib/Domain/Builders/Faceted/PagePropertyBuilder.cs(1 hunks)lib/Domain/Requests/Facets/PageProperties.cs(1 hunks)lib/Infrastructure/Constants.cs(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
lib/Domain/Requests/Facets/PageProperties.cs (1)
lib/Infrastructure/Constants.cs (5)
Constants(18-294)Gotenberg(51-293)Chromium(175-292)Shared(211-291)PageProperties(226-255)
🔇 Additional comments (2)
lib/Infrastructure/Constants.cs (1)
253-254: LGTM! Clean constant addition following established patterns.The new
SinglePageconstant follows the existing naming conventions and is properly placed within thePagePropertiesclass. The camelCase value"singlePage"is consistent with other form field names in the constants.lib/Domain/Builders/Faceted/PagePropertyBuilder.cs (1)
45-50: Excellent implementation following the builder pattern.The
SetSinglePagemethod is well-implemented with:
- Consistent naming convention with other
Set*methods- Proper method chaining by returning the builder instance
- Reasonable default value (
true) for the optional parameter- Clean, focused implementation
Summary by CodeRabbit
Fix #57