Skip to content

Recap but Svelte #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: dev
Choose a base branch
from
Draft

Recap but Svelte #40

wants to merge 8 commits into from

Conversation

flloschy
Copy link

@flloschy flloschy commented Jan 4, 2025

As I said Id like to help out on this Project!
I also said Id prefer SvelteKit, and thus here I am!

This is kinda like a proof of concept but also somewhat usable already.
Proof of concept because there is A LOT to be done still (for starters the UI is missing)
Somewhat usable because it works well for the few things it can already do

Ive put the most useful information in the Readme like Project Structure and current State

And Thanks for making the Rewind in the first place! Not only is it a fun thing and well made, its also a fun project to work on! (partly because the research is already made (this jellyfin interface/api thing for example is relatively similar) so thanks for that too)

Looking forward to catching up with the real rewind :)

And just to be totally on the same page, this is a Draft for a reason and there is LOTS of things to be done to get somewhat close to the real thing but luckily I have about 300 days to go :D

Copy link

netlify bot commented Jan 4, 2025

Deploy Preview for keen-bublanina-30b4ef failed.

Name Link
🔨 Latest commit e310174
🔍 Latest deploy log https://app.netlify.com/sites/keen-bublanina-30b4ef/deploys/6786eab2cd69750008761dd2

@flloschy
Copy link
Author

flloschy commented Jan 4, 2025

Ohh god i didnt know there are automated checks, I guess ill keep the commits on the lower end then. Woups

@Chaphasilor
Copy link
Owner

Hey, thanks for this! I'm curious, what would be the concrete benefits of Svelte?
I've heard good things about it, but initially wanted to keep this project as vanilla as possible, hence the use of ArrowJS as the "framework". I personally have experience with Vue, and interacted with a React project in the past.

I know the project is due for some serious refactoring, but I always thought it would continue to be regular JavaScript (or rather TypeScript).

Also, don't worry about the checks. These are just for automatic builds, and expect certain config files to be present. But they're not really checking anything (aside from the build working).

@flloschy
Copy link
Author

flloschy commented Jan 5, 2025

Uhh I dont know how to start, there are quite a few things I believe svelte has the edge over but to be transparent a lot of them are primarily opinions.

For example, the UI is a standalone file which you can use as a normal HTML file with its own script, body and styling which wont effect other pages. I find this quiet a bit more organized and readable than having [parts of] the HTML inside a script file.

It works with Typescript out of the box, dont know about arrowJS though, couldnt find many resources

The code in ts files or in script tags is just vanilla, only when using code inside the HTML part its obviously not vanilla since it will be processed but those code snippets themself are still vanilla

The project structure Svelte "forces" (more like heavily suggests) is also fairly good, readable, organized and just feel very natural to me

When building for Production and visiting the site it will be a single page application which makes navigating really smooth and it loads pages on the go which makes the initial load quiet fast. (While looking for resources on performance I only just now found out that Svelte is or is very close to the best performing framework with near "the performance of optimized vanilla JS" (-Reditor) :O)

I was worried about checks because of the messages which will flood my and probably your inbox haha
But if you say so I'll quickly cleanup the code a bit and push the welcome+login pages so far, this way you can see how a more legit (in reference to the current temporary page) UI looks in svelte :)

(Edit: Oh I didnt know the netlify comment will be updated, I thought it will send a new message every time)

@Chaphasilor
Copy link
Owner

Okay, next question: why prettier over deno? I like that Dart/Flutter and Rust have default formatters, and never liked Prettier much myself. Or was deno used just for formatting, not as a Node alternative?

@flloschy
Copy link
Author

flloschy commented Jan 6, 2025

Oh wow, thanks for mentioning!
I tried the deno formatter again and now it works...
before it formatted some files into some hybrid of onelines with linebreaks inside strings and such which broke everything and now I cant even reproduce it xd
Im truly cursed at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants