-
Notifications
You must be signed in to change notification settings - Fork 1
Use new json-event-parser create API #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0.x versions don't provide any stability guarantees, see https://semver.org/#spec-item-4: Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable. |
I'm going to address this in our dependabot auto-merge workflow. It may cause issues in other repositories too as dependabot workflow was copied over from spark-evaluate repository. |
I have addressed this problem in this PR #43 |
It could cause issues, but we haven't experienced them yet. We are auto-approving only selected dependencies. A trivial way to avoid this issue is excluding pre-1.0 dependencies from the list of dependencies to auto-approve. Let's not worry about this in other repositories now; we have more important things to work on. |
Signed-off-by: Miroslav Bajtoš <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM.
I added 0331d69 to avoid event.clone()
.
Do you happen to have StateMarketDeals.json.zst
around? It would be great to compare the output from the current and the new version, to ensure there are no regressions introduced.
…into feat/upgrade-json-event-parser-api
…oin-station/fil-deal-ingester into feat/upgrade-json-event-parser-api
…into feat/upgrade-json-event-parser-api
Sadly I don't have it but I'm going to download it for sake of testing. |
@bajtos I've parsed |
Awesome, thanks for checking 🙏🏻 |
This PR addresses breaking changed caused by automatic upgrade of
json-event-parser
create done by dependabot. New version of this package, although with minor semver upgrade, has a breaking API change.