Skip to content

Use new json-event-parser create API #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 16, 2025

Conversation

pyropy
Copy link
Contributor

@pyropy pyropy commented Jan 15, 2025

This PR addresses breaking changed caused by automatic upgrade of json-event-parser create done by dependabot. New version of this package, although with minor semver upgrade, has a breaking API change.

@pyropy pyropy self-assigned this Jan 15, 2025
@pyropy pyropy mentioned this pull request Jan 15, 2025
@bajtos
Copy link
Member

bajtos commented Jan 15, 2025

This PR addresses breaking changed caused by automatic upgrade of json-event-parser create done by dependabot. New version of this package, although with minor semver upgrade, has a breaking API change.

0.x versions don't provide any stability guarantees, see https://semver.org/#spec-item-4:

Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable.

@pyropy
Copy link
Contributor Author

pyropy commented Jan 15, 2025

This PR addresses breaking changed caused by automatic upgrade of json-event-parser create done by dependabot. New version of this package, although with minor semver upgrade, has a breaking API change.

0.x versions don't provide any stability guarantees, see https://semver.org/#spec-item-4:

Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable.

I'm going to address this in our dependabot auto-merge workflow. It may cause issues in other repositories too as dependabot workflow was copied over from spark-evaluate repository.

@pyropy
Copy link
Contributor Author

pyropy commented Jan 15, 2025

This PR addresses breaking changed caused by automatic upgrade of json-event-parser create done by dependabot. New version of this package, although with minor semver upgrade, has a breaking API change.

0.x versions don't provide any stability guarantees, see https://semver.org/#spec-item-4:
Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable.

I'm going to address this in our dependabot auto-merge workflow. It may cause issues in other repositories too as dependabot workflow was copied over from spark-evaluate repository.

I have addressed this problem in this PR #43

@bajtos
Copy link
Member

bajtos commented Jan 16, 2025

It may cause issues in other repositories too as dependabot workflow was copied over from spark-evaluate repository.

It could cause issues, but we haven't experienced them yet.

We are auto-approving only selected dependencies. A trivial way to avoid this issue is excluding pre-1.0 dependencies from the list of dependencies to auto-approve.

Let's not worry about this in other repositories now; we have more important things to work on.

Signed-off-by: Miroslav Bajtoš <[email protected]>
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM.

I added 0331d69 to avoid event.clone().

Do you happen to have StateMarketDeals.json.zst around? It would be great to compare the output from the current and the new version, to ensure there are no regressions introduced.

@bajtos bajtos requested a review from NikolasHaimerl January 16, 2025 08:52
@pyropy
Copy link
Contributor Author

pyropy commented Jan 16, 2025

Code changes LGTM.

I added 0331d69 to avoid event.clone().

Do you happen to have StateMarketDeals.json.zst around? It would be great to compare the output from the current and the new version, to ensure there are no regressions introduced.

Sadly I don't have it but I'm going to download it for sake of testing.

@pyropy
Copy link
Contributor Author

pyropy commented Jan 16, 2025

Code changes LGTM.
I added 0331d69 to avoid event.clone().
Do you happen to have StateMarketDeals.json.zst around? It would be great to compare the output from the current and the new version, to ensure there are no regressions introduced.

Sadly I don't have it but I'm going to download it for sake of testing.

@bajtos I've parsed StateMarketDeals.json.zst using two binaries, one using json-event-parser version 0.1.1. and the other one using the 0.2.0 version and compared files using cmp and they are equal.

@pyropy pyropy marked this pull request as ready for review January 16, 2025 12:47
@pyropy pyropy merged commit c038677 into main Jan 16, 2025
5 checks passed
@pyropy pyropy deleted the feat/upgrade-json-event-parser-api branch January 16, 2025 12:47
@bajtos
Copy link
Member

bajtos commented Jan 16, 2025

Sadly I don't have it but I'm going to download it for sake of testing.

@bajtos I've parsed StateMarketDeals.json.zst using two binaries, one using json-event-parser version 0.1.1. and the other one using the 0.2.0 version and compared files using cmp and they are equal.

Awesome, thanks for checking 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants