-
Notifications
You must be signed in to change notification settings - Fork 1
Revert "Fix parsing snapshot file" #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit f02b4e1.
Converted to draft to prevent accidental early merge after approval |
The first commit lgtm, but what about the second one, labeled |
Are you sure this can be merged? |
After I opened the revert PR clippy was complaining which indicates that in between the firs time the code was changed and now, clippy was reconfigured. This meant I needed to run clippy locally to fix the formatting issues. It seems like the commenting of the run.sh file which I did for verifying the original solution from Srdjan slipped in. I removed this commenting. |
For my awareness, what is clippy? |
Clippy is a linting tool for rust, similar to how we use prettier in Javascrpt. |
Yes, I checked it against the current version of the snapshot. |
I think this is a repo setting, should we update it to require a PR and approval before merging? |
My comment was referring to the clippy commit |
Not necessarily, making it a draft just prevents any kind of accidental merge situation |
Interesting, and it also lints shell files? |
No, I do not think it lints shell files. |
I see, the clippy commit was aiming at fixing the lining issue that clippy was raising. |
Reverts #85
The change in schema was a bug that was introduced and will be reverted.
See the conversation here: https://space-meridian.slack.com/archives/C023K7D9GAX/p1751283455545599