Skip to content

Fix test for discovery module and change state to only_service_labels #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2024
Merged

Fix test for discovery module and change state to only_service_labels #612

merged 1 commit into from
Jun 4, 2024

Conversation

Max-checkmk
Copy link
Contributor

@Max-checkmk Max-checkmk commented Jun 4, 2024 •
edited by robin-checkmk
Loading

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

  • Testing against 2.3.0p3 with only_service_labels option for the single service discovery is now possible
  • Tests are failing anyway, because this was initially introduced as "update_service_labels"

What is the new behavior?

  • Changed state from "update_service_labels" to "only_service_labels"
  • Changed tests so they work with 2.3.0p3

Other information

@Max-checkmk Max-checkmk added module:discovery This affects the discovery module release:5.0.0 Affects the mentioned release. labels Jun 4, 2024
@Max-checkmk Max-checkmk self-assigned this Jun 4, 2024
lgetwan
lgetwan approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@lgetwan lgetwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@robin-checkmk robin-checkmk merged commit d37ab09 into devel Jun 4, 2024
50 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2024
@robin-checkmk robin-checkmk deleted the Fix-test-for-discovery-module branch June 4, 2024 21:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lgetwan lgetwan lgetwan approved these changes

@robin-checkmk robin-checkmk Awaiting requested review from robin-checkmk robin-checkmk is a code owner

Assignees

@Max-checkmk Max-checkmk

Labels
module:discovery This affects the discovery module release:5.0.0 Affects the mentioned release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Max-checkmk @lgetwan @robin-checkmk