added support for big numbers and sending > 9007 XCH #642

seeden · 2022-03-04T19:55:32Z

added support for big numbers and sending more than 9007 XCH
fixed formatting for big numbers

lgtm-com · 2022-03-04T20:00:24Z

This pull request introduces 7 alerts when merging 2fbdb3e into 672cf2a - view on LGTM.com

new alerts:

7 for Unused variable, import, function or class

packages/api/src/utils/toSafeNumber.ts

packages/core/src/utils/bigNumberToLocaleString.ts

paninaro · 2022-03-04T22:56:45Z

There are a small number of files that still use JSON.parse() and JSON.stringify(). Should we be using JSONbig everywhere, and if so, is there some way we can enforce its usage (custom ESLint warning?)

packages/api/src/Message.ts

packages/api/src/utils/toSafeNumber.ts

packages/api/package.json

packages/core/package.json

packages/core/src/utils/chiaFormatter.ts

ChiaMineJP · 2022-03-06T06:28:03Z

packages/wallets/src/components/WalletGraph.tsx

@@ -145,7 +146,8 @@ function generateTransactionGraphData(
      TransactionType.OUTGOING_TRADE,
    ].includes(type);

-    const value = (amount + feeAmount) * (isOutgoing ? -1 : 1);
+    const total = BigNumber(amount).plus(BigNumber(feeAmount));
+    const value = isOutgoing ? total.negated() : total;


I think some comment should be added.
I expect if isOutgoing === false then it is incoming, but readers may not be sure about this assumption.

ChiaMineJP · 2022-03-06T06:34:13Z

packages/wallets/src/components/WalletGraph.tsx

@@ -196,8 +202,8 @@ function prepareGraphPoints(
  const points = [
    {
      x: peakTransaction.confirmedAtHeight,
-      y: Math.max(0, Number(mojoToChia(start))),
-      tooltip: mojoToChia(balance),
+      y: BigNumber.max(0, mojoToChia(start)).toNumber(), // max 21,000,000 safe to number


I'm doubtful about this // max 21,000,000 safe to number

But if this is used as only visualization, it causes no harm. Fixing comment will suffice.

ChiaMineJP · 2022-03-06T06:34:40Z

packages/wallets/src/components/WalletGraph.tsx

@@ -208,8 +214,8 @@ function prepareGraphPoints(

    points.push({
      x: timestamp,
-      y: Math.max(0, Number(mojoToChia(start))),
-      tooltip: mojoToChia(start),
+      y: BigNumber.max(0, mojoToChia(start)).toNumber(), // max 21,000,000 safe to number


The same with above comment.

ChiaMineJP · 2022-03-06T06:46:09Z

packages/wallets/src/components/WalletHistory.tsx

@@ -4,7 +4,7 @@ import { Trans } from '@lingui/macro';
 import moment from 'moment';
 import { Box, IconButton, Table as TableBase, TableBody, TableCell, TableRow, Tooltip, Typography, Chip } from '@material-ui/core';
 import { CallReceived as CallReceivedIcon, CallMade as CallMadeIcon, ExpandLess as ExpandLessIcon, ExpandMore as ExpandMoreIcon } from '@material-ui/icons';
-import { Card, CardKeyValue, CopyToClipboard, Flex, Loading, StateColor, TableControlled, toBech32m, useCurrencyCode, mojoToChiaLocaleString, mojoToCATLocaleString } from '@chia/core';
+import { Card, CardKeyValue, CopyToClipboard, Flex, Loading, StateColor, TableControlled, toBech32m, useCurrencyCode, mojoToChia, mojoToCAT, FormatLargeNumber } from '@chia/core';
 import { useGetOfferRecordMutation, useGetSyncStatusQuery } from '@chia/api-react';
 import styled from 'styled-components';
 import type { Row } from '@chia/core';


It seems Row is not exported from @chia/core.

packages/core/index.ts
export * from './components'; export * from './constants'; export * from './utils'; export * from './hooks'; export * from './theme'; export * from './screens'; export * as locales from './locales';

packages/core/components/index.ts
... export { default as Table, TableControlled } from './Table'; ...

packages/core/components/Table/index.ts
export { default } from './Table'; export { default as TableControlled } from './TableControlled';

packages/wallets/src/components/card/WalletCardPendingBalance.tsx

ChiaMineJP · 2022-03-06T08:08:31Z

packages/wallets/src/components/offers/OfferEditorRowData.ts

spendBalance should be BigNumber because in packages/wallets/src/components/offers/OfferEditorConditionsPanel.tsx, there is line:
```
balance = mojoToChia(walletBalance.spendableBalance);
...
row.spendableBalance = balance;
```

packages/wallets/src/components/offers/OfferEditorConditionsPanel.tsx

Line61: if (balanceString !== row.spendableBalanceString || balance !== row.spendableBalance) {
balance is BigNumber so native !== does not work.

packages/gui/src/components/block/Block.jsx

Line307 ${baseFarmerReward} ${currencyCode}:
baseFarmerReward is BigNumber, so by including in string template, BigNumber.toString() is implicitly called.
BigNumber.toString() can be 2.5e-11. Is it allowed? If not please consider using BigNumber.toFixed()

packages/gui/src/components/farm/card/FarmCardBlockRewards.tsx

Need to check and update whole lines.

packages/wallets/src/components/did/WalletDID.tsx

Line 615. {mojoToChiaLocaleString(props.balance)} TXCH Is this OK? Maybe not relevant to this PR though.

packages/gui/src/util/chia.js

Replace big.js with bignumber.js for whole lines.

packages/gui/src/types/Transaction.ts

Shouldn't type of amount, sent and fee_amount be number|BigNumber?

packages/api-react/src/services/wallet.ts

Line263-264 BigInt should be replaced by BigNumber.

The value of PendingBalance will be later passed to useWalletHumanValue but it does not expect that value may be BigInt.
There may be lines where BigNumber must be used foruint64/uint128 properties.

lgtm-com · 2022-03-06T20:48:20Z

This pull request introduces 7 alerts when merging 90ea447 into 672cf2a - view on LGTM.com

new alerts:

7 for Unused variable, import, function or class

lgtm-com · 2022-03-06T20:53:52Z

This pull request introduces 7 alerts when merging d00b450 into 672cf2a - view on LGTM.com

new alerts:

7 for Unused variable, import, function or class

packages/api-react/src/services/wallet.ts

lgtm-com · 2022-03-09T15:22:42Z

This pull request introduces 1 alert when merging e049ded into 85e2e98 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

lgtm-com · 2022-03-09T19:08:23Z

This pull request introduces 1 alert when merging 596c6d3 into f8f218c - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

lgtm-com · 2022-03-10T15:37:51Z

This pull request introduces 1 alert when merging 50dd2e6 into cdfa2b9 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

added support for big numbers and sending more then 9007 XCH

2fbdb3e

seeden requested review from paninaro and ChiaMineJP March 4, 2022 19:55

seeden mentioned this pull request Mar 4, 2022

Fixed a crash after pasting malicious string to amount/fee input #635

Closed

paninaro reviewed Mar 4, 2022

View reviewed changes

packages/api/src/utils/toSafeNumber.ts Show resolved Hide resolved

paninaro reviewed Mar 4, 2022

View reviewed changes

packages/core/src/utils/bigNumberToLocaleString.ts Outdated Show resolved Hide resolved

paninaro reviewed Mar 4, 2022

View reviewed changes

packages/core/src/utils/bigNumberToLocaleString.ts Outdated Show resolved Hide resolved

paninaro reviewed Mar 4, 2022

View reviewed changes

packages/core/src/utils/bigNumberToLocaleString.ts Show resolved Hide resolved

ChiaMineJP reviewed Mar 6, 2022

View reviewed changes

BigInt => BigNumber

90ea447

removed unused code

d00b450

seeden added 7 commits March 6, 2022 21:55

deps

0664cf3

LGTM

1391e7b

removed unused code

7bb933a

removed unused dep

ca58504

fixed typo

090aff8

removed unused dep

21d5a36

used args instead of array

7eb5878

ChiaMineJP requested changes Mar 7, 2022

View reviewed changes

packages/api-react/src/services/wallet.ts Outdated Show resolved Hide resolved

seeden added 6 commits March 9, 2022 15:50

used custom convert bytes to iec

f7da9c3

removed current instance because it is immutable

fcb7506

fixed pending balance

4406823

added missing type

d906083

used mojo directly because it is BigNumber

e0f5868

typo

5ad914f

removed unused file

e049ded

fixed formating on farm page

596c6d3

first version of bignumbers for offers

50dd2e6

Editable exchange rate fields in the offer editor

a37332b

emlowe mentioned this pull request Apr 20, 2022

[Bug] White screening of the GUI window for mac (intel) occurs after large tx Chia-Network/chia-blockchain#11108

Closed

seeden closed this Apr 22, 2022

seeden deleted the big_numbers branch April 22, 2022 16:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added support for big numbers and sending > 9007 XCH #642

added support for big numbers and sending > 9007 XCH #642

seeden commented Mar 4, 2022

lgtm-com bot commented Mar 4, 2022

paninaro commented Mar 4, 2022

ChiaMineJP Mar 6, 2022

ChiaMineJP Mar 6, 2022

ChiaMineJP Mar 6, 2022

ChiaMineJP Mar 6, 2022

ChiaMineJP commented Mar 6, 2022 •

edited

Loading

lgtm-com bot commented Mar 6, 2022

lgtm-com bot commented Mar 6, 2022

lgtm-com bot commented Mar 9, 2022

lgtm-com bot commented Mar 9, 2022

lgtm-com bot commented Mar 10, 2022

added support for big numbers and sending > 9007 XCH #642

added support for big numbers and sending > 9007 XCH #642

Conversation

seeden commented Mar 4, 2022

lgtm-com bot commented Mar 4, 2022

paninaro commented Mar 4, 2022

ChiaMineJP Mar 6, 2022

Choose a reason for hiding this comment

ChiaMineJP Mar 6, 2022

Choose a reason for hiding this comment

ChiaMineJP Mar 6, 2022

Choose a reason for hiding this comment

ChiaMineJP Mar 6, 2022

Choose a reason for hiding this comment

ChiaMineJP commented Mar 6, 2022 • edited Loading

packages/wallets/src/components/offers/OfferEditorRowData.ts

packages/wallets/src/components/offers/OfferEditorConditionsPanel.tsx

packages/gui/src/components/block/Block.jsx

packages/gui/src/components/farm/card/FarmCardBlockRewards.tsx

packages/wallets/src/components/did/WalletDID.tsx

packages/gui/src/util/chia.js

packages/gui/src/types/Transaction.ts

packages/api-react/src/services/wallet.ts

lgtm-com bot commented Mar 6, 2022

lgtm-com bot commented Mar 6, 2022

lgtm-com bot commented Mar 9, 2022

lgtm-com bot commented Mar 9, 2022

lgtm-com bot commented Mar 10, 2022

ChiaMineJP commented Mar 6, 2022 •

edited

Loading