CHIA-3107 Simplify test_basic_coin_store #19709
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmineKhaldi
added
the
Changed
arvidn
reviewed
Jun 12, 2025
| block.get_included_reward_coins(), | ||
| tx_additions, | ||
| tx_removals, | ||
| block.height, block.foliage_transaction_block.timestamp, reward_coins, tx_additions, tx_removals |
There was a problem hiding this comment.
This is just a formatting change, right?
I think the existing formatting is preferred. I don't think this is a simplification. Is it?
There was a problem hiding this comment.
I'm changing this call to avoid recomputing reward_coins.
There was a problem hiding this comment.
Suggested change
| block.height, block.foliage_transaction_block.timestamp, reward_coins, tx_additions, tx_removals | |
| block.height, | |
| block.foliage_transaction_block.timestamp, | |
| reward_coins, | |
| tx_additions, | |
| tx_removals, |
| assert block.foliage_transaction_block is not None | ||
| assert block.foliage_transaction_block is not None | ||
| await coin_store.new_block( | ||
| block.height, block.foliage_transaction_block.timestamp, reward_coins, tx_additions, tx_removals |
There was a problem hiding this comment.
This is just a formatting change, right?I think the existing formatting is preferred.
There was a problem hiding this comment.
I'm changing this call to avoid recomputing reward_coins.
There was a problem hiding this comment.
I see, the reward_coins parameter. It's harder to spot when you change formatting at the same time
There was a problem hiding this comment.
Suggested change
| block.height, block.foliage_transaction_block.timestamp, reward_coins, tx_additions, tx_removals | |
| block.height, | |
| block.foliage_transaction_block.timestamp, | |
| reward_coins, | |
| tx_additions, | |
| tx_removals, |
AmineKhaldi
force-pushed
the
simplify_test_basic_coin_store
branch
from
2bab407 to
bf31fea
Compare
AmineKhaldi
force-pushed
the
simplify_test_basic_coin_store
branch
from
bf31fea to
442c81d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Simplify
test_basic_coin_storeby skipping non transaction blocks where appropriate, leveragingadditions_and_removalsinstead of the combination ofget_name_puzzle_conditionsandtx_removals_and_additions, and avoiding to recompute reward coins.Current Behavior:
New Behavior:
Testing Notes: