Split out the nil and non-verified checks

Chia-Network · Aug 18, 2024 · 6173a8f · 6173a8f
1 parent cb1f000
commit 6173a8f
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/internal/github/checkUnsigned.go b/internal/github/checkUnsigned.go
@@ -87,9 +87,12 @@ func hasUnsignedCommits(ctx context.Context, githubClient *github.Client, pr *gi
 				continue
 			}
 			verification := commit.Commit.Verification
-			if verification == nil || !*verification.Verified {
+			if verification == nil {
+				slogs.Logr.Info("Commit has no verification field", "commit_sha", commit.GetSHA(), "author", commit.Commit.Author.GetName(), "email", commit.Commit.Author.GetEmail())
+				return true, nil // Log and flag if no verification field
+			} else if !*verification.Verified {
 				slogs.Logr.Info("Commit is not verified", "commit_sha", commit.GetSHA(), "author", commit.Commit.Author.GetName(), "email", commit.Commit.Author.GetEmail(), "reason", verification.GetReason())
-				return true, nil
+				return true, nil // Log and flag if the commit is not verified
 			}
 		}
 		unsignedCancel() // Clean up the context at the end of the loop iteration