Fix for Issue 233 #235
Open
Fix for Issue 233 #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated posixify to remove periods and upper AM/PM
updated param x description
|
@JordanMPDS I believe you want to connect with @nicklucius for consideration of the pull request, thank you |
|
Yes, am waiting for a reply for Nick. Only mentioned you since you originally raised the issue and suggested potential fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting PR as potential fix for #233. Two fixes, one as @geneorama suggested to remove periods within %p as this will fix not only macOS but also other locals that use this. Also, forcing AM/PM to be in upper as some locales default to lower and this would also cause a failure.
And suggested update to param description since the email said it was too vague.