WIP: CFAVML-NONE: Add ndarray extension library #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # cfavml/src/safe_trait_agg_ops.rs # cfavml/src/safe_trait_arithmetic_ops.rs # cfavml/src/safe_trait_cmp_ops.rs # cfavml/src/safe_trait_distance_ops.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As CFAVML's operations increase we want to be able to use them within ndarray operations, to do that we are adding some extension traits that provide
fast_*trait based operations as well as a function based utilities which IMO are cleaner than the trait calling.Currently, this is a WIP as the only thing that is really working currently is the V1 logic of broadcasting different arrays and applying the operator.