Updates for GNOME Shell 49 and improves logging #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applies formatting changes based on updated Prettier configuration. Refactors code for improved readability and maintainability by removing unnecessary imports and simplifying code structures.
Updates metadata to support GNOME Shell version 49. Replaces direct `console.error` and `console.log` calls with the extension's logger for better debugging and consistency.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the extension for GNOME Shell 49 compatibility and standardizes logging through the extension’s logger.
- Bumps
shell-versionandversion-namein metadata for Shell 49 support - Replaces all
console.log/console.errorcalls withthis.getLogger().log/.error - Applies one-line formatting to several
.connect()calls and adds editor/formatter configs
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| prefs.js | Swapped out console.* for this.getLogger() and inlined connects |
| extension.js | Replaced console.error with this.getLogger().error and inlined calls |
| menu_items.js | Condensed if and removed formatting around array splices |
| metadata.json | Updated shell-version to include "49" and bumped version-name |
| .prettierrc | Added printWidth and bracketSameLine options |
| .editorconfig | Introduced basic EditorConfig rules with indent settings |
Comments suppressed due to low confidence (1)
[email protected]/prefs.js:265
- [nitpick] Variable
buttonfilechooseruses inconsistent casing compared to other camelCase identifiers. Rename tobuttonFileChooserfor clarity and consistency.
buttonfilechooser.set_tooltip_text(_("Usually located in '/usr/share/applications'"));
| _(_settings.get_string("label-menu")), | ||
| "" | ||
| ); | ||
| this.menu.setHeader("preferences-other-symbolic", _(_settings.get_string("label-menu")), ""); |
There was a problem hiding this comment.
[nitpick] You’ve wrapped a translated string in another translation call (_(_settings.get_string(...))). Consider using a single _() invocation or passing the already translated string directly.
Copilot uses AI. Check for mistakes.
| (posRel < 0 && index > 0) || | ||
| (posRel > 0 && index < items.length - 1) | ||
| ) { | ||
| if ((posRel < 0 && index > 0) || (posRel > 0 && index < items.length - 1)) { | ||
| let temp = items[index]; | ||
| items.splice(index, 1); | ||
| items.splice(parseInt(index) + posRel, 0, temp); |
There was a problem hiding this comment.
Using parseInt on index (already a number) is unnecessary. You can simplify to items.splice(index + posRel, 0, temp);.
Suggested change
| items.splice(parseInt(index) + posRel, 0, temp); | |
| items.splice(index + posRel, 0, temp); |
Copilot uses AI. Check for mistakes.
Comment on lines
+270
to
277
| const errorLog = (...args) => { | ||
| this.getLogger().error("Error:", ...args); | ||
| }; | ||
| const handleError = (error) => { | ||
| errorLog(error); | ||
| return null; | ||
| }; | ||
| const appRow = await myAppChooser.showChooser().catch(handleError); |
There was a problem hiding this comment.
You’ve redefined errorLog and handleError inside this click handler only. Consider extracting them into a shared helper or method to avoid duplication and improve reuse.
Suggested change
| const errorLog = (...args) => { | |
| this.getLogger().error("Error:", ...args); | |
| }; | |
| const handleError = (error) => { | |
| errorLog(error); | |
| return null; | |
| }; | |
| const appRow = await myAppChooser.showChooser().catch(handleError); | |
| const appRow = await myAppChooser.showChooser().catch(this._handleError.bind(this)); |
Copilot uses AI. Check for mistakes.
Extends the install script to allow creating a zip file through the "pack" argument, mirroring the functionality of the "zip" argument. This provides more flexibility in how the extension is packaged.
ChrisLauinger77
force-pushed
the
gnome49
branch
4 times, most recently
from
6a1269a to
32d95a3
Compare
Corrects the extension installation process by using the correct zip file name, ensuring proper installation and activation. Simplifies menu item parsing by directly accessing the split data, improving code readability and maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the extension to be compatible with GNOME Shell 49.
console.errorandconsole.logcalls with the extension's logger for better consistency and control over logging.