Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add MP3Reader class for mp3 file reader #194

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Deepchavda007
Copy link

@Deepchavda007 Deepchavda007 commented Sep 3, 2024

Description

  • Summary: This PR introduces a new feature that adds the MP3Reader class for reading and processing MP3 files to extract text data.

  • Related Issue: This feature was developed to enhance the capability of the project to handle audio input, specifically MP3 files, and convert them into a textual format

Type of change

  • New features (non-breaking change).

Checklist

  • I have performed a self-review of my code.
  • I have added thorough tests if it is a core feature.
  • The feature is well documented.

@cin-albert cin-albert self-requested a review September 13, 2024 09:58
Copy link
Collaborator

@cin-albert cin-albert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Deepchavda007,
I believe this PR is not finished yet. Please add the Reader to the list of file extractors and make it visible in the UI.
References:

KH_DEFAULT_FILE_EXTRACTORS: dict[str, BaseReader] = {
".xlsx": PandasExcelReader(),
".docx": unstructured,
".pptx": unstructured,
".xls": unstructured,
".doc": unstructured,
".html": HtmlReader(),
".mhtml": MhtmlReader(),
".png": unstructured,
".jpeg": unstructured,
".jpg": unstructured,
".tiff": unstructured,
".tif": unstructured,
".pdf": PDFThumbnailReader(),
".txt": TxtReader(),
".md": TxtReader(),
}

@Deepchavda007
Copy link
Author

Deepchavda007 commented Sep 18, 2024

@cin-albert Implemented the changes as per your suggestion. Please review the updated code. Thank you!

@Deepchavda007 Deepchavda007 marked this pull request as draft September 24, 2024 12:52
@Deepchavda007 Deepchavda007 marked this pull request as ready for review September 24, 2024 12:52
@Deepchavda007 Deepchavda007 changed the title Add MP3Reader class for mp3 file read Add MP3Reader class for mp3 file reader Sep 24, 2024
@Deepchavda007 Deepchavda007 changed the title Add MP3Reader class for mp3 file reader feat: Add MP3Reader class for mp3 file reader Oct 10, 2024
@Deepchavda007
Copy link
Author

@taprosoft @cin-albert Is there anything else needed from my end, or any additional feedback before it can be merged? Thanks for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants