IOSXR: fix AS parsing for dynamic neighbors #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional 'show version' support for different versions of ASA software
…elease_21.6 Releasing v21.6
Show Redundancy regex update to accommodate eXR
ShowRunInterface - fixed channel_group and added new output parsing
Added show sdwan tunnel sla index 0 parser
Corrected mistake on naming convention with folder based testing for show sdwan tunnel sla index 0
The regexes used were too restrictive. They matched IPv4 addresses, and IPv6 addresses that contain only numbers. (eg, 192.168.0.1, 2001:123::) They did NOT match any IPv6 addresses with 'a-f' characters. (eg, 2001:456:abc::)
IOSXR - Fix for issue#492 -ShowBgpInstanceAllAll-- dotted ASN not captured
…owBgpInstanceProcessDetail iosxr-ShowBgpInstanceProcessDetail - Fix RegEx
…security NEW: Add ShowSecurityPoliciesHitCount to JUNOS
…elease_21.8 Release 21.8
…ahigash_ga_add_makejson added make json to github actions
Dynamic neighbors get an additional "Dynamic" property on the line where remote and local AS are specified: ``` Remote AS 65498, local AS 65499, external link, Dynamic ``` Currently, the regex to parse this line expects a precise set of properties and reject any unkown property. I propose to extend the regex to accept and discard any unknown property. It seems better than to return neighbors without local/remote AS, as this is quite an essential information.
|
Perhaps it would be better to capture it and add it to the schema as an Optional() key. That way it will get captured and recorded if it's there and if it's not there the schema would continue as normal. Either way you're correct that the regex needs to be able to handle additional properties. Thank you for catching this! |
danielgraziano
approved these changes
Oct 4, 2021
|
@vincentbernat are you planning to fix up what @GerriorL was proposing? |
No, sorry, I currently don't have time. |
danielgraziano
force-pushed
the
master
branch
from
b9b60d4 to
df3a58b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic neighbors get an additional "Dynamic" property on the line
where remote and local AS are specified:
Currently, the regex to parse this line expects a precise set of
properties and reject any unkown property. I propose to extend the
regex to accept and discard any unknown property. It seems better than
to return neighbors without local/remote AS, as this is quite an
essential information.
Checklist: