Junos ping form routing instance #633
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-the-iii
suggested changes
Mar 7, 2022
Comment on lines
+10
to
+12
| * junos | ||
| * Modified ping.py | ||
| * Added routing instance support |
There was a problem hiding this comment.
Please put this changelog in the 2022/undistributed folder, the release engineer will handle putting it in this file.
Comment on lines
+97
to
+105
| "ping {addr}", | ||
| "ping {addr} count {count}", | ||
| "ping {addr} ttl {ttl} count {count} wait {wait}", | ||
| "ping {addr} source {source} count {count}", | ||
| "ping {addr} source {source} size {size} do-not-fragment count {count}", | ||
| "ping {addr} source {source} size {size} count {count} tos {tos} rapid", | ||
| "ping {addr} size {size} count {count} do-not-fragment", | ||
| "ping {addr} routing-instance {routing_instance} count {count}", | ||
| "ping {addr} routing-instance {routing_instance} source {source} count {count}" |
There was a problem hiding this comment.
please stop changing all the quoting, it's fine the way it is
Comment on lines
+156
to
+157
| r"^PING +(?P<address>\S+) +\((?P<source>\S+)\): +" | ||
| r"(?P<data_bytes>\d+) +data +bytes$" |
There was a problem hiding this comment.
change the quoting back on all the patterns
| @@ -198,45 +231,59 @@ def cli(self, addr, count=None, ttl=None, | |||
| m = p2.match(line) or p2_2.match(line) | |||
| if m: | |||
| group = m.groupdict() | |||
| result_list = ping_dict.setdefault('result', []) | |||
| result_list = ping_dict.setdefault("result", []) | |||
| continue | ||
|
|
||
| # round-trip min/avg/max/stddev = 1.823/2.175/2.399/0.191 ms | ||
| m = p4.match(line) | ||
| if m: | ||
| group = m.groupdict() | ||
| round_trip_dict = ping_statistics_dict.setdefault('round-trip', {}) | ||
| round_trip_dict.update({k.replace('_', '-'):v for k, v in group.items() if v is not None}) | ||
| round_trip_dict = ping_statistics_dict.setdefault("round-trip", {}) |
Comment on lines
+276
to
+279
| "lsping-statistics": { | ||
| "send": int, | ||
| "received": int, | ||
| "loss-rate": int, |
| class PingMplsRsvp(PingMplsRsvpSchema): | ||
|
|
||
| cli_command = 'ping mpls rsvp {rsvp}' | ||
| cli_command = "ping mpls rsvp {rsvp}" |
Comment on lines
+104
to
+105
| "ping {addr} routing-instance {routing_instance} count {count}", | ||
| "ping {addr} routing-instance {routing_instance} source {source} count {count}" |
There was a problem hiding this comment.
You haven't added any section to the parser cli command caller that will run entry 7 or 8, making this do nothing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added routing-instance support to the ping command. No changes to returned dictionary.
Motivation and Context
The ping command in the current release doesn't work if run from a routing-instance.
Impact (If any)
No impact.
Screenshots:
Checklist: