Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for 'show image version' in ArubaOS #640

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ykoehler
Copy link

@ykoehler ykoehler commented Mar 11, 2022

Description

Added parsing for 'show image version' within ArubaOS

Motivation and Context

New CLI command support

Impact (If any)

Screenshots:

2022-03-11 16:59:33,012: %UNICON-INFO: +++ thomas-mm with via 'cli': executing command 'show image version' +++
show image version

----------------------------------
Partition               : 0:0 (/mnt/disk1)
Software Version        : ArubaOS 8.6.0.16 (Digitally Signed SHA1/SHA256 - Production Build)
Build number            : 82590
Label                   : 82590
Built on                : Thu Dec 16 13:28:34 UTC 2021
----------------------------------
Partition               : 0:1 (/mnt/disk2) **Default boot**
Software Version        : ArubaOS 8.10.0.0 LSR (Digitally Signed SHA1/SHA256 - Developer/Internal Build)
Build number            : 0000
Label                   : [email protected]
Built on                : Wed Mar 9 09:41:5
(ArubaMM-VA_AF_70_12) *[mynode] #
{'thomas-mm': {'partition': {0: {'disk': '/mnt/disk1', 'firmware_version': 'ArubaOS 8.6.0.16', 'signature_type': 'SHA1/SHA256', 'build_type': 'Production', 'build_number': 82590, 'label': '82590', 'built_on': 'Thu Dec 16 13:28:34 UTC 2021'}, 1: {'disk': '/mnt/disk2', 'firmware_version': 'ArubaOS 8.10.0.0 LSR', 'signature_type': 'SHA1/SHA256', 'build_type': 'Developer/Internal', 'build_number': 0, 'label': '[email protected]', 'built_on': 'Wed Mar 9 09:41:5'}, 'default_partition': 1}}}
(pyats) root@c2942142d6df:/pyats# 

Checklist:

  • I have updated the changelog.
  • I have updated the documentation (If applicable).
  • I have added tests to cover my changes (If applicable).
  • All new and existing tests passed.
  • All new code passed compilation.

@ykoehler ykoehler requested a review from a team as a code owner March 11, 2022 17:00
@ykoehler ykoehler requested review from GerriorL and d-the-iii March 11, 2022 17:00
@ykoehler
Copy link
Author

Hi, I was unclear if the unittest need to be in /tests or in /src/.../arubaos/tests/

also, didn't figure out how I could run them localy.

@tahigash tahigash requested review from bastell and removed request for d-the-iii April 22, 2022 21:19
@ykoehler
Copy link
Author

ykoehler commented Jun 1, 2022

ok, sorry for all those delay, took a while to get back on this since I was making inquiry within my company to see if I was allowed to submit such code etc...

Apparently I am ok to submit such code, but neeed to do so on my work email, so I will cancel this PR and re-submit with my work email [email protected]

@GerriorL
Copy link
Contributor

GerriorL commented Aug 9, 2022

Hi Yannick,
If you have opened a new PR with a different email, could you please comment the link to the new PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants