-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aireos parsers #666
base: main
Are you sure you want to change the base?
Add aireos parsers #666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Goutham,
Please add some tests to cover these new parsers. You can find a guide on how to create folder tests here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, in the future, if possible, please divide the multiple parsers/APIs into multiple PRs, maybe max 2 of them per PR so that it's easier and faster to review and follow up. Fow now, please add the unit tests and add the test log in the description part as Liam suggested.
Description
Added new parsers for aireos
Motivation and Context
This change is required so that genie can parse the outputs for various aireos commands like -
'show sysinfo'
'show ap summary'
'show wlan summary'
'show redundancy summary' etc.
Impact (If any)
None - just adding new parsers
Screenshots:
N/A
Checklist: