Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aireos parsers #666

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

Goutham4914
Copy link

Description

Added new parsers for aireos

Motivation and Context

This change is required so that genie can parse the outputs for various aireos commands like -
'show sysinfo'
'show ap summary'
'show wlan summary'
'show redundancy summary' etc.

Impact (If any)

None - just adding new parsers

Screenshots:

N/A

Checklist:

  • [x ] I have updated the changelog.
  • I have updated the documentation (If applicable).
  • I have added tests to cover my changes (If applicable).
  • [x ] All new and existing tests passed.
  • [x ] All new code passed compilation.

@Goutham4914 Goutham4914 requested a review from a team as a code owner June 2, 2022 19:40
@Goutham4914 Goutham4914 requested review from sjpatel21 and stevedhn June 2, 2022 19:40
Copy link
Contributor

@GerriorL GerriorL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Goutham,

Please add some tests to cover these new parsers. You can find a guide on how to create folder tests here

Copy link

@stevedhn stevedhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, in the future, if possible, please divide the multiple parsers/APIs into multiple PRs, maybe max 2 of them per PR so that it's easier and faster to review and follow up. Fow now, please add the unit tests and add the test log in the description part as Liam suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants