Added show nat, show access-list, handled split line routes and added values to show bgp neighbors #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… hex of the form 0xfffffff. The schema expected a string.
… so returned None and setdefault was then called on that
…controls_flows and adjusted tests accordingly
…e line number and changed integer fields to use integer instead of string. Fixed bugs thrown by tests and adapted tests to new formatting
Updating upstream master into MikeJames15/genieparser to resolve conflicts
… under entry and entries expanded from objects under group-expansion, moved destination outside of source which is no longer needed with the expansion
…and handled split lines due to long output. Also replaced if not in assign in dicts with calls to setdefault()
…ng localprf. The comparison was looking for greater than 10 spaces to mean that metric is present when it should have been less than 11 since metric interrupts the consecutive spaces.
…when it contains an empty string
… hex of the form 0xfffffff. The schema expected a string.
… so returned None and setdefault was then called on that
…controls_flows and adjusted tests accordingly
…e line number and changed integer fields to use integer instead of string. Fixed bugs thrown by tests and adapted tests to new formatting
… under entry and entries expanded from objects under group-expansion, moved destination outside of source which is no longer needed with the expansion
…ng localprf. The comparison was looking for greater than 10 spaces to mean that metric is present when it should have been less than 11 since metric interrupts the consecutive spaces.
… with and without details. Fixed comments
Interfaces were optional and so was source and destination and flags. The entry_num regex was looking for \d* which matched a zero length digit so an empty string would match it.
…e schema but not in the regex that extracts them. Made them mandatory in both
…ts were not getting initialized properly. Valid conns rate line was not parsed properly. Renamed perfmon_stats_per_sec to stats_per_sec. context variable was being used erroneously as group name and as dictionary creating unpredictable behaviour
…bers. I decided it would be better to have it in text as one_min and five_min respectively.
Taarini
requested changes
Jul 11, 2022
omehrabi
reviewed
Aug 11, 2022
| @@ -0,0 +1,8 @@ | |||
| -------------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
please merge all the changelogs
GerriorL
requested changes
Aug 12, 2022
| @@ -0,0 +1,273 @@ | |||
| ''' show_access_list.py | |||
There was a problem hiding this comment.
File should be named show_acl.py for consistency with other OSes
| """ | ||
|
|
||
| schema = { | ||
| Optional('access-list'): { |
There was a problem hiding this comment.
Suggested change
| Optional('access-list'): { | |
| Optional('access_list'): { |
| # access-list acl1 line 4 extended deny ip any4 any4 log informational interval 300 (hitcnt=0) 0xffffffff | ||
| # access-list acl1 line 5 extended deny ip any6 any6 log informational interval 300 (hitcnt=0) 0xffffffff | ||
| # access-list al_iga_to_sl line 2 extended permit tcp 10.1.1.0 255.255.255.224 range 1 10 10.2.1.0 255.255.255.0 informational interval 300 (hitcnt=0) 0xb5386dd9 | ||
| p2 = re.compile(r'(?P<tabbed> +)?access-list +(?P<name>\S+) +line +(?P<entry>\d+) +extended +(?P<action>(permit|deny)) +(object-group (?P<svc_obj_group>\S+)|(?P<protocol>\S+)) +(host (?P<src_host>\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})|object-group +(?P<src_object_group>\S+)|(?P<src_any>any4|any6|any)|((?P<src_network>\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}) +(?P<src_mask>\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}))|(object (?P<src_object>\S+)))( +(?P<src_port_op>eq|lt|neq|range) +(?P<src_port>\S+))?( +(?P<src_to_port>(?!host|object-group|any4|any6|any)[0-9a-zA-Z]+))? +(host (?P<dst_host>\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})|object-group +(?P<dst_object_group>\S+)|(?P<dst_any>any4|any6|any)|((?P<dst_network>\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}) +(?P<dst_mask>\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}))|(object (?P<dst_object>\S+)))( +(?P<dst_port_op>eq|lt|neq|range) +(?P<dst_port>[0-9a-zA-Z]+))?( +(?P<dst_to_port>((?!log)\S+)))?( +log(?P<log_disable> +disable)?)?( +informational +interval +(?P<informational_interval>\d+))? +\(hitcnt=(?P<hitcnt>\d+)\) +(?P<acl_hash>0x[0-9a-fA-F]+)') |
There was a problem hiding this comment.
Please watch the line length. Try not to exceed 80-120 characters on each line
Taarini
requested changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added two parsers for asa:
- "show access-list"
- "show nat"
Modified show bgp all neighbors routes on iosxe:
- to always have a path value even if it is empty
- handled split lines
Modified show bgp all neighbors on iosxe:
- added last_read, last_write, up_time, down_time
Motivation and Context
Missing parsers/values
Impact (If any)
Screenshots:
Checklist: