Added AOS Show Commands #701
Conversation
|
I recently got Aruba OS (aos) merged into the unicon plugin. This opens Aruba OS to anybody that wants to contribute to the genieparser project. I have already created 4 show commands to get started with. |
|
I have an SDK folder with sample output results. Please let me know if I need to remove that. |
There was a problem hiding this comment.
Hi Alex! Thank you for this submission, and for the initiative in getting AOS supported. I do have some feedback.
Firstly, there is no need to create a new file for each parser. Parsers that operate off the same or closely related parent commands can be added to the same file. For examples all of the 'show interfaces' commands could be added to a single 'show_interfaces.py'; there is no need to have interfaces brief and interfaces transceiver listed separately.
Next, when it comes to writing the tests for your parser I'd like to refer you to our contribution guide, where you can find instructions for creating a Folder Test.
When it comes to the parsers themselves, I should mentions that schema keys should only be made optional only when there's no other way to address the device's possible outputs. For the commands you're parsing here, if there is a column in the output table that may or may not be filled, then an optional key is helpful for that column only.
Lastly it would be best to remove the sdk/ folder as you mentioned.
| else: | ||
| out = output | ||
|
|
||
| # This matches the report portion of the show vlan command. |
There was a problem hiding this comment.
I think that the file could be cleaned up a bit by having the comments at the appropriate level of indentation for the code
| Optional('vlan_id'): str, | ||
| Optional('name'): str, | ||
| Optional('status'): str, | ||
| Optional('voice'): str, | ||
| Optional('jumbo'): str, |
There was a problem hiding this comment.
Do all of these need to be optional? Optional keys are best used when it's possible for only part of a line to show up. Overusing optional can lead to parsers passing when they should otherwise have failed
| Only one changelog file per pull request. Combine these two templates where applicable. | ||
|
|
||
| Templates | ||
| ========= | ||
|
|
There was a problem hiding this comment.
| Only one changelog file per pull request. Combine these two templates where applicable. | |
| Templates | |
| ========= |
Description
Motivation and Context
The commands for Aruba OS are different than Cisco IOS, IOSXE, IOSXR, etc.
Checklist: