Implement 1-hour rolling window approach to min-binning#192
Closed
Nate-Wessel wants to merge 66 commits intodeployfrom
Closed
Implement 1-hour rolling window approach to min-binning#192Nate-Wessel wants to merge 66 commits intodeployfrom
Nate-Wessel wants to merge 66 commits intodeployfrom
Conversation
It's just a grouping var anyway and this makes the intermediate python output easier to read
no need to do calculations for data we'll throw out in the next step
does this actually save any bandwidth or space? I don't know but it feels like it could
incidentaly, I did satisfy my curiousity and verified that hmean of the speed is the same as average of the travel time
thanks to Gabe for spotting this!
still need to define bins also by their ends
Member
Author
|
Still need to adjust the join of the bins back onto the data, as that's still a rolling join based on the bin ends. |
Member
Author
|
There's some inefficient code in here, but I'm pretty sure the logic per se is now sound. |
Merged
Member
Author
|
Closing this in favour of #228 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working toward an approach where the binning window rolls along, discarding observations >= one hour older than its leading edge.
This would serve to prevent data from being aggregated together over long spans because of