Feature/Modernize-the-code #2

ClausKlein · 2025-03-16T19:01:14Z

No description provided.

Fix gcovr.cfg too

Correct error handling Update copyright notice

ClausKlein · 2025-03-18T08:46:04Z

async_tcp_client.cpp

@@ -213,7 +215,7 @@ class client
    if (!error)
    {
      // Extract the newline-delimited message from the buffer.
-      std::string const line(input_buffer_.substr(0, n - 1));
+      std::string const line = input_buffer_.substr(0, n - 1);  // NOTE: w/o '\n'


use initialiser list {}

ClausKlein · 2025-03-18T08:47:19Z

async_tcp_client.cpp

-    // XXX [this](const boost::system::error_code& /*e*/, PH1) {
-    // handle_write(std::forward<decltype(PH1)>(PH1)); });
+    boost::asio::async_write(socket_, boost::asio::buffer(message),
+        [this, self](const boost::system::error_code& error, std::size_t) { handle_write(error); });


prevent use of this!

ClausKlein · 2025-03-18T08:47:56Z

async_tcp_client.cpp

-    // handle_read(std::forward<decltype(PH1)>(PH1),
-    // std::forward<decltype(PH2)>(PH2)); });
+    boost::asio::async_read_until(socket_, boost::asio::dynamic_buffer(input_buffer_), '\n',
+        [this, self](const boost::system::error_code& error, std::size_t n) { handle_read(error, n); });


prevent use of this!

ClausKlein · 2025-03-18T08:49:44Z

async_tcp_client.cpp

    // Put the actor back to sleep.
-    // cpp11: deadline_.async_wait(std::bind(&client::check_deadline, this));
-    deadline_.async_wait([this](const boost::system::error_code& /*e*/) { check_deadline(); });
+    deadline_.async_wait([this, self](const boost::system::error_code& /*e*/) { check_deadline(); });


prevent use of this!

ClausKlein · 2025-03-18T08:50:40Z

async_tcp_client_v20.cpp

+
+      // Start an asynchronous operation to send the message.
+      boost::asio::async_write(socket_, boost::asio::buffer(message),
+          [this, self](const boost::system::error_code& error, std::size_t) { handle_write(error); });


prevent use of this!

ClausKlein · 2025-03-18T08:51:40Z

async_tcp_echo_client.cpp

@@ -137,18 +149,18 @@ class AsynchronousTCPClient : public std::enable_shared_from_this< AsynchronousT
          });
    }

-    boost::asio::async_read_until(socket_, boost::asio::dynamic_buffer(data_), CR,
+    boost::asio::async_read_until(socket_, boost::asio::dynamic_buffer(data_), STOP,
        [this, self](boost::system::error_code ec, std::size_t length)


prevent use of this!

ClausKlein · 2025-03-18T08:52:27Z

async_tcp_client_v20.cpp

+    auto self(shared_from_this());
+
+    // Put the actor back to sleep.
+    deadline_.async_wait([this, self](const boost::system::error_code& /*e*/) { check_deadline(); });


prevent use of this!

ClausKlein · 2025-03-18T08:52:55Z

async_tcp_client_v20.cpp

+
+    // Start an asynchronous operation to read a newline-delimited message.
+    boost::asio::async_read_until(socket_, boost::asio::dynamic_buffer(input_buffer_), '\n',
+        [this, self](const boost::system::error_code& error, std::size_t n) { handle_read(error, n); });


prevent use of this!

ClausKlein · 2025-03-18T08:53:22Z

async_tcp_client_v20.cpp

+
+    // Start an asynchronous operation to send a heartbeat message.
+    boost::asio::async_write(socket_, boost::asio::buffer(message),
+        [this, self](const boost::system::error_code& error, std::size_t) { handle_write(error); });


prevent use of this!

ClausKlein · 2025-03-18T08:53:58Z

rrcp_async_tcp_client.cpp

+  {
+    auto self(shared_from_this());
+    boost::asio::async_write(socket_, boost::asio::buffer(write_msgs_.front()),
+        [this, self](boost::system::error_code ec, std::size_t /*length*/)


prevent use of this!

Fix typos too

ClausKlein added 10 commits March 16, 2025 13:07

Use enable_shared_from_this<>

d724ccd

Prevent more clang-tidy warnings

2584f7c

Fix gcovr.cfg too

Try to fix heartbeat handling

00f89a5

Add signal handler to async server

4bc35b9

Add Signal and error handling

baa04bb

Cleanup the code

93f3383

Modernize rrcp_helper

4e30d6c

Modernize and format the code again

e4b1a82

Add rrcp_async_tcp_client.cpp

a171a77

The final cut

ad0a22c

Correct error handling Update copyright notice

ClausKlein force-pushed the feature/tests-without-queue branch from 02e4fb2 to ad0a22c Compare March 17, 2025 16:23

ClausKlein added 3 commits March 17, 2025 18:13

Add more ctests

f5b917c

Prevent runtime_error exections

4fd771f

Use a write msg queue

796d3d0

ClausKlein commented Mar 18, 2025

View reviewed changes

ClausKlein and others added 6 commits March 18, 2025 20:03

Reorder the test data set

bf8e59a

Add Base64 encoding

0088fe6

Add more base64 tests

2ed3e66

Add even more tests

78dc2c7

Change base64 tests according to RFC

889a54e

Add examples too

03229b0

ClausKlein added 2 commits March 20, 2025 13:30

Fix format in Readme

d67e4ad

Fix typos too

Move base64 reference docu into tests

798db5b

ClausKlein self-assigned this Mar 20, 2025

Changes after review

4bd1aa2

ClausKlein merged commit a34e2d3 into develop Mar 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/Modernize-the-code #2

Feature/Modernize-the-code #2

ClausKlein commented Mar 16, 2025

ClausKlein Mar 18, 2025

ClausKlein Mar 18, 2025

ClausKlein Mar 18, 2025

ClausKlein Mar 18, 2025

ClausKlein Mar 18, 2025

ClausKlein Mar 18, 2025

ClausKlein Mar 18, 2025

ClausKlein Mar 18, 2025

ClausKlein Mar 18, 2025

ClausKlein Mar 18, 2025

Feature/Modernize-the-code #2

Feature/Modernize-the-code #2

Conversation

ClausKlein commented Mar 16, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment