Fix clang 21 warnings

[a666]

Summary

Build "Fix clang 21 warnings"

Purpose of change

Recently arch linux updated clang from 20.1.8 to 21.1.4.

This made a new compilation warning appear.

error: function 'operator()' could be declared with attribute 'noreturn' [-Werror,-Wmissing-noreturn]

Describe the solution

Added __attribute__((noreturn)) to lambdas with the warning.

Describe alternatives you've considered

I have minimal experience with c++ projects, I'm unsure if this is the correct solution (code quality wise? a better way to set these attributes?), if someone with more experience could provide guidance that would be helpful.
Perhaps it would be better to just disable the warning in the Makefile?
I don't have any preference for a solution, I'm open to amending the commit.

Testing

Game compiles with clang and g++ without warnings, visual studio compilation untested since I'll go feral the moment I'll use f***ing Windows for anything.

Additional context

https://releases.llvm.org/21.1.0/tools/clang/docs/ReleaseNotes.html

[ehughsbaird]

This is a bug in clang 21.1.4, fixed in clang 22 llvm/llvm-project#154493.

I think filing a report requesting a backport is preferable to trying to use a language feature that isn't quite here yet (see the failing Windows build).
If we do choose to work around it here, until C++23 provides the language support for this, the attributes will need to be specified as a macro so that only clang see them.

#ifdef __clang__
#define LAMBDA_NORETURN __attribute__( ( noreturn ) )
#else
#define LAMBDA_NORETURN
#end

[a666]

I wasn't sure were to put the #define to make it DRY so I made a new header.
If there's a better place I'll move it.

[ehughsbaird]

Could you rename it to cata_compiler_support.h? You could also absorb cata_inline.h into it, but don't need to. Please also add a comment mentioning that it can be removed and replaced with [[noreturn]] with C++23 (for all compilers).

[a666]

Did the CI windows build https://github.com/CleverRaven/Cataclysm-DDA/actions/runs/18880894748/job/53883387286?pr=83499 just hit #82635 ?

[ehughsbaird]

Looks good, thank you!