Add Kvass

[BalthazarArgall]

Summary

Content "Add Kvass"

Purpose of change

Kvass is quite popular in eastern europe, I expect immigrants in NE to miss it and seek to make it themselves, or just people wanting to try it out. It's also a very easy easy to make DIY soda, I would expect that in post-apocalyptic situations this could gain quite a lot of popularity, it's not like we're going to run out of soda but still...

Describe the solution

Add it, with its recipe.

It should be noted that kvass is a fermented drink, so it needs to be brewed for a few days beforehand. It should also be noted that the recipe produces 4L of kvass at a time, this may be a bit much but I can't split the fruits component, and if you want to make less just spill it if there's too much.

Describe alternatives you've considered

• No natural spawn, this would require some non trivial research and preexisting content (like special stores). I may add spawns in fridges in the future.
• I could have included an additional step where you drain the kvass, maybe someone could add an intermediate unstrained kvass in the future with reduced fun values.

Testing

Spawned some, drank it, looks fine. Recipe also looks fine. Haven't tested the brewing part.

Additional context

Recipe sources:

1. https://www.youtube.com/watch?v=pvPvuIVN32U&t=16s
2. https://natashaskitchen.com/angelinas-easy-bread-kvas-recipe/
3. https://ancestralkitchen.com/2020/11/02/russian-bread-kvass-ancestral-cook-up-november-2020/

Fixes #83504, please do note that I'm only doing this because it's interesting to me, I'm not automatically going to be implementing your food suggestions.

[Maddremor]

What is the quench value based on?

[BalthazarArgall]

It's based on lemonade.

[PatrikLundell]

Doesnt' this cause kvass to be brewable into itself due to inheritance, or does the removal of the BREWABLE subtype prevent the inherited fields to be usable (or, possibly, even inherited at all)?

I'd also suggest the actual brewing should be tested to ensure it works as intended.

I don't think it makes sense to make the recipe auto learned: it ought to come from a book(s), or, theoretically,, from a creation trait of slavic traditional origin, or something like that (which there isn't any support for, as far as I know, though you might make it a "hobby"), to explain why you've learned the recipe.

[BalthazarArgall]

Fair enough, I'll test the brewing process.

As for the autolearn bit, I'm not sure what "autolearn" represents, my thought process was, as you said, that since we can't evaluate if you're more or less likely to know a recipe for cultural reasons we just assume that you know it but maybe that's not what autolearn should be.

[PatrikLundell]

As far as I understand, auto learn is intended for stuff that's trivial if you have the general skills of the skill level, because you can easily figure out the details. So, making a sandwich in various themes is trivial for anyone who hasn't been locked out of the kitchen by servants (in some cases known as parents) in places where sandwiches are a common part of the culture, such as the US, for instance.

[BalthazarArgall]

You were right on the brewing issue, it was recursive, I thought the brewing code relied on the BREWABLE subtype or some kind of id matching shenanigans. Fixed it.

As for the autolearn issue I'll wait for someone else to comment, I am less sure about it but I want to be certain that I'm wrong, we have plenty of items that I implemented where that wasn't an issue, maybe it always was or this is a special case but I want another opinion (I still value yours to be clear).

[PatrikLundell]

Well, there's a reason it was a comment and not a request, so that's fine.

[Maleclypse]

"autolearn" : [ // Automatically learned upon gaining listed skills
[ "survival", 2 ],
[ "fabrication", 3 ]
],

It's not autolearned at cooking 1

[Maddremor]

Kvass seems pretty niche in New England, so is it really something someone would arrive to by ambient knowledge or by first principles?