Allow variants for brewing and composting results #83599
+90
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Documentation>
|
I realize this is not the way your PR is going, and I am not trying to tell you it should, but... Have you considered the idea of moving to a recipe-based system like milling? Recipes already have support for producing selected variants. |
|
It seems like milling produces single outputs, whereas brewing typically has multiple outputs. Brewable items are also already crafted, with recipes involving heating, which a recipe in this context could not do. I am not sure that is as appropriate to apply here. |
It would probably be nicer to use a struct instead of a pair here, but not that much.
ehughsbaird
force-pushed
the
brew-result
branch
from
9645b6f to
0c81895
Compare
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Infrastructure "Allow specifying variants for brewing and compost results"
Purpose of change
Fixes #83584
Describe the solution
Replace itype with pair<itype, string>. Set the variant on creation. Add a reader to handle the format.
Testing
Add an item with a variant to brewing results.
Additional context
nnameis problematic for variants and I don't know how to handle it.