-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deep convection to gcm-driven SCM setup #3364
base: main
Are you sure you want to change the base?
Conversation
0ff34b7
to
7733cb7
Compare
7733cb7
to
0341135
Compare
The parameters change looks good to me. Gabriele can take a look at the code change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you turn forcing_type
into a julia type and use dispatch instead of matching strings?
0341135
to
990f3b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good (altough, I think that it is more efficient to dispatch over the first argument). Could you please add some documentation, docstrings, and expand upon what the config external_forcing_type
is?
Your help message for external_forcing_type
is "External forcing type"
, which doesn't teach much
Actually, I think we should add these time scales to parameters instead of having a type. No need to change it now, but whoever uses it or changes it again for other types (e.g. reanalysis) should use parameters instead I think. |
990f3b1
to
67b0d4c
Compare
Add relaxation timescale for deep convection in gcm-driven SCM setup