Refactor latest_comparable_paths
#3443
Open
+28
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@szy21 pointed out that our long runs were broken due to the reproducibility tests. It looks like #3437 removed this check, which means that the long runs try to run some reproducibility infrastructure in the plot comparison against main part of the driver.
We should probably make that orthogonal to the repro tests, but I had plans to refactor
latest_comparable_pathsanyway, so this PR adds that check back in, and changes to usingcompute_bins, which is unit tested (as well aslatest_comparable_paths), and this fixes a bug inlatest_comparable_pathsin that we will no longer incorrectly compare against potentially incompatible commits after reverted commits (when duplicate reference counters exist on main).