Add new AtmosSimulation
constructor
#3999
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adds a new AtmosSimulation constructor, closes #3894.
The current
AtmosConfig
/parsed_args
system is monolithic and hard to use programmatically. This PR introduces a more composable constructor that makes it easier to create simulations programmatically and reduces coupling between configuration parsing and simulation setup.Content
AtmosSimulation
constructor that provides a cleaner API without requiringAtmosConfig
/parsed_args
SphereDomain
,ColumnDomain
, etc.) to replace parsed_args-based spatial configuration. This could use ClimaCore directly, as mentioned by @Sbozzolo.default_model_callbacks
to get callbacks from model info.common_callbacks
for standard simulation callbacks (NaN checks, conservation, etc.)To-do
get_callbacks
andcommon_callbacks
dt
netcdf_interpolation_num_points
andnetcdf_output_at_levels
get_simulation