Skip to content

Conversation

@haakon-e
Copy link
Member

@haakon-e haakon-e commented Oct 14, 2025

This pull request extends the configurability of the Smagorinsky-Lilly turbulence model by allowing users to specify whether the model should be applied in the horizontal direction only, vertical direction only, both together, or each separately. This enhancement is reflected in configuration options, documentation, and the underlying implementation.

Smagorinsky-Lilly model configurability:

  • Added support for new configuration options for the Smagorinsky-Lilly model: UV (horizontal only), W (vertical only), and UV_W (horizontal and vertical treated separately), in addition to the existing UVW (all directions). (config/default_configs/default_config.yml, src/solver/model_getters.jl, src/solver/types.jl) [1] [2] [3]
  • Updated the assertion in get_smagorinsky_lilly_model to allow the new configuration symbols. (src/solver/model_getters.jl)
  • Improved documentation for the Smagorinsky-Lilly model to describe all possible configuration flags and their effects. (src/solver/model_getters.jl, src/solver/types.jl) [1] [2]

Implementation logic:

  • Updated logic in set_smagorinsky_lilly_precomputed_quantities! to correctly compute horizontal and vertical length scales (ᶜL_h, ᶜL_v) depending on the chosen model configuration. (src/parameterized_tendencies/les_sgs_models/smagorinsky_lilly.jl)
  • Modified the is_smagorinsky_vertical and is_smagorinsky_horizontal helper functions to recognize the new configuration options. (src/solver/types.jl) [1] [2]

@haakon-e haakon-e force-pushed the he/rft-split-h-v-smag branch 2 times, most recently from a9489f1 to e8efcff Compare October 16, 2025 01:12
@haakon-e haakon-e force-pushed the he/rft-split-h-v-smag branch 2 times, most recently from 167a52b to d9bb09b Compare October 23, 2025 18:42
@haakon-e
Copy link
Member Author

haakon-e commented Oct 23, 2025

@haakon-e haakon-e changed the base branch from main to he/face-density October 23, 2025 18:42
@haakon-e haakon-e force-pushed the he/rft-split-h-v-smag branch from d9bb09b to 7b5867e Compare October 23, 2025 18:48
@haakon-e haakon-e force-pushed the he/rft-split-h-v-smag branch from 7b5867e to 1419465 Compare October 23, 2025 18:55
@haakon-e haakon-e force-pushed the he/face-density branch 2 times, most recently from 1d80d53 to d9b10d4 Compare October 23, 2025 19:12
@haakon-e haakon-e force-pushed the he/rft-split-h-v-smag branch from 1419465 to ebd19d2 Compare October 23, 2025 19:12
@haakon-e haakon-e force-pushed the he/rft-split-h-v-smag branch 2 times, most recently from 2649dbf to 530c4c5 Compare October 23, 2025 19:26
@haakon-e haakon-e force-pushed the he/rft-split-h-v-smag branch 2 times, most recently from 76c0bb2 to 03076a8 Compare October 24, 2025 16:20
@haakon-e haakon-e changed the base branch from he/face-density to he/rft-smag-for-h-v-split October 24, 2025 17:24
@haakon-e haakon-e force-pushed the he/rft-split-h-v-smag branch from 03076a8 to a3f50ce Compare October 24, 2025 17:24
@haakon-e haakon-e force-pushed the he/rft-smag-for-h-v-split branch from f208904 to 5b71280 Compare October 24, 2025 17:32
@haakon-e haakon-e force-pushed the he/rft-split-h-v-smag branch from a3f50ce to ebf2bde Compare October 24, 2025 17:32
@haakon-e haakon-e force-pushed the he/rft-smag-for-h-v-split branch from 5b71280 to 096387a Compare October 24, 2025 18:06
@haakon-e haakon-e force-pushed the he/rft-split-h-v-smag branch from ebf2bde to 1ef438f Compare October 24, 2025 18:06
@haakon-e haakon-e force-pushed the he/rft-smag-for-h-v-split branch from 096387a to c5146ea Compare October 24, 2025 18:10
@haakon-e haakon-e force-pushed the he/rft-split-h-v-smag branch from 1ef438f to 652005b Compare October 24, 2025 18:10
@haakon-e haakon-e requested a review from trontrytel October 24, 2025 18:13
@haakon-e haakon-e force-pushed the he/rft-smag-for-h-v-split branch from c5146ea to 5735cee Compare October 24, 2025 21:40
@haakon-e haakon-e force-pushed the he/rft-split-h-v-smag branch from 652005b to 3451592 Compare October 24, 2025 21:40
@haakon-e haakon-e force-pushed the he/rft-smag-for-h-v-split branch from 5735cee to 87a105c Compare October 24, 2025 22:00
@haakon-e haakon-e force-pushed the he/rft-split-h-v-smag branch from 3451592 to 6aef76c Compare October 24, 2025 22:00
@haakon-e haakon-e force-pushed the he/rft-smag-for-h-v-split branch from 87a105c to 2469091 Compare October 27, 2025 17:00
@haakon-e haakon-e force-pushed the he/rft-split-h-v-smag branch from 6aef76c to ca70a86 Compare October 27, 2025 17:00
@haakon-e haakon-e force-pushed the he/rft-smag-for-h-v-split branch from 2469091 to 8c5c1b8 Compare October 27, 2025 18:20
@haakon-e haakon-e force-pushed the he/rft-split-h-v-smag branch from ca70a86 to 91316b4 Compare October 27, 2025 18:20
Copy link
Member

@trontrytel trontrytel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@haakon-e haakon-e force-pushed the he/rft-smag-for-h-v-split branch 2 times, most recently from ec7aa18 to a82a107 Compare October 28, 2025 01:17
@haakon-e haakon-e force-pushed the he/rft-split-h-v-smag branch from 91316b4 to 3b790f9 Compare October 28, 2025 01:21
Base automatically changed from he/rft-smag-for-h-v-split to main October 28, 2025 03:52
@haakon-e haakon-e added this pull request to the merge queue Oct 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 28, 2025
@haakon-e haakon-e added this pull request to the merge queue Oct 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 28, 2025
@haakon-e haakon-e force-pushed the he/rft-split-h-v-smag branch from 3b790f9 to d2186c3 Compare October 28, 2025 22:14
@haakon-e haakon-e enabled auto-merge October 28, 2025 22:27
- add diffusivity diagnostics
- implicit vertical smagorinsky
- les ci_plots edits
- use vertical strain for lilly correction
- full strain rate method
@haakon-e haakon-e force-pushed the he/rft-split-h-v-smag branch from d2186c3 to 2fbb8cf Compare October 28, 2025 23:53
@haakon-e haakon-e added this pull request to the merge queue Oct 29, 2025
Merged via the queue into main with commit 05af764 Oct 29, 2025
28 of 32 checks passed
@haakon-e haakon-e deleted the he/rft-split-h-v-smag branch October 29, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants