-
Notifications
You must be signed in to change notification settings - Fork 26
rft: split Smagorinsky diffusive model to horizontal and vertical components #4054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a9489f1 to
e8efcff
Compare
167a52b to
d9bb09b
Compare
Member
Author
|
This change is part of the following stack: Change managed by git-spice. |
d9bb09b to
7b5867e
Compare
9ffce7f to
550f133
Compare
7b5867e to
1419465
Compare
1d80d53 to
d9b10d4
Compare
1419465 to
ebd19d2
Compare
d9b10d4 to
0db5c3e
Compare
2649dbf to
530c4c5
Compare
0db5c3e to
6c5903a
Compare
76c0bb2 to
03076a8
Compare
6c5903a to
c6e9e44
Compare
03076a8 to
a3f50ce
Compare
This was referenced Oct 24, 2025
f208904 to
5b71280
Compare
a3f50ce to
ebf2bde
Compare
5b71280 to
096387a
Compare
ebf2bde to
1ef438f
Compare
096387a to
c5146ea
Compare
1ef438f to
652005b
Compare
c5146ea to
5735cee
Compare
652005b to
3451592
Compare
5735cee to
87a105c
Compare
3451592 to
6aef76c
Compare
87a105c to
2469091
Compare
6aef76c to
ca70a86
Compare
2469091 to
8c5c1b8
Compare
ca70a86 to
91316b4
Compare
trontrytel
approved these changes
Oct 27, 2025
Member
trontrytel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
ec7aa18 to
a82a107
Compare
91316b4 to
3b790f9
Compare
1 task
3b790f9 to
d2186c3
Compare
haakon-e
commented
Oct 28, 2025
- add diffusivity diagnostics - implicit vertical smagorinsky - les ci_plots edits - use vertical strain for lilly correction - full strain rate method
d2186c3 to
2fbb8cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request extends the configurability of the Smagorinsky-Lilly turbulence model by allowing users to specify whether the model should be applied in the horizontal direction only, vertical direction only, both together, or each separately. This enhancement is reflected in configuration options, documentation, and the underlying implementation.
Smagorinsky-Lilly model configurability:
UV(horizontal only),W(vertical only), andUV_W(horizontal and vertical treated separately), in addition to the existingUVW(all directions). (config/default_configs/default_config.yml,src/solver/model_getters.jl,src/solver/types.jl) [1] [2] [3]get_smagorinsky_lilly_modelto allow the new configuration symbols. (src/solver/model_getters.jl)src/solver/model_getters.jl,src/solver/types.jl) [1] [2]Implementation logic:
set_smagorinsky_lilly_precomputed_quantities!to correctly compute horizontal and vertical length scales (ᶜL_h,ᶜL_v) depending on the chosen model configuration. (src/parameterized_tendencies/les_sgs_models/smagorinsky_lilly.jl)is_smagorinsky_verticalandis_smagorinsky_horizontalhelper functions to recognize the new configuration options. (src/solver/types.jl) [1] [2]